Issue metadata
Sign in to add a comment
|
[A11y Assessment - Status Tray] Missing label for audio settings button |
||||||||||||||||||||||||
Issue descriptionOS: Chrome Tested on Canary (61) but experienced in previous versions The headphone icon button (audio settings) has no label. All I hear is "button", which is embarrassing.
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c43d568f440a09f116b23cafd8ba065021b0ff2 commit 4c43d568f440a09f116b23cafd8ba065021b0ff2 Author: Sammie Quon <sammiequon@google.com> Date: Thu Sep 28 00:35:35 2017 a11y: Make actionable_view and tray_item_more use button's accessible name members. It seems some subclass of actionable_view which use SetAccessibleName actually use button's impl of SetAccessibleName which then leaves |accessible_name_| empty in actionable_view, so ChromeVox will then not read anything. There is at least one instance which occurs in system tray, the audio settings button (the other actionable_views are not affected because they have their own GetAVXNodeData impl's). This cl removes SetAccessibleName and accessible_name_ from subclasses of Button. These classes will just use Button::SetAccessibleName and Button::accessible_name() instead. Test: manual Bug: 747469 Change-Id: I03bde6e90ed3b22321585eccccb4cc2c32e5b5ef Reviewed-on: https://chromium-review.googlesource.com/678061 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#504814} [modify] https://crrev.com/4c43d568f440a09f116b23cafd8ba065021b0ff2/ash/system/tray/actionable_view.cc [modify] https://crrev.com/4c43d568f440a09f116b23cafd8ba065021b0ff2/ash/system/tray/actionable_view.h [modify] https://crrev.com/4c43d568f440a09f116b23cafd8ba065021b0ff2/ash/system/tray/tray_item_more.cc [modify] https://crrev.com/4c43d568f440a09f116b23cafd8ba065021b0ff2/ash/system/tray/tray_item_more.h [modify] https://crrev.com/4c43d568f440a09f116b23cafd8ba065021b0ff2/ui/views/controls/button/button.cc [modify] https://crrev.com/4c43d568f440a09f116b23cafd8ba065021b0ff2/ui/views/controls/button/button.h
,
Sep 28 2017
,
Jan 22 2018
,
Jan 23 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sammiequon@chromium.org
, Sep 21 2017Status: Assigned (was: Available)