New issue
Advanced search Search tips

Issue 747469 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

[A11y Assessment - Status Tray] Missing label for audio settings button

Project Member Reported by lpalmaro@chromium.org, Jul 21 2017

Issue description

OS: Chrome
Tested on Canary (61) but experienced in previous versions 

The headphone icon button (audio settings) has no label. All I hear is "button", which is embarrassing. 
 
Owner: sammiequon@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c43d568f440a09f116b23cafd8ba065021b0ff2

commit 4c43d568f440a09f116b23cafd8ba065021b0ff2
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Sep 28 00:35:35 2017

a11y: Make actionable_view and tray_item_more use button's accessible
name members.

It seems some subclass of actionable_view which use SetAccessibleName
actually use button's impl of SetAccessibleName which then leaves
|accessible_name_| empty in actionable_view, so ChromeVox will then not
read anything. There is at least one instance which occurs in system
tray, the audio settings button (the other actionable_views are not
affected because they have their own GetAVXNodeData impl's).

This cl removes SetAccessibleName and accessible_name_ from subclasses
of Button. These classes will just use Button::SetAccessibleName and
Button::accessible_name() instead.

Test: manual
Bug:  747469 
Change-Id: I03bde6e90ed3b22321585eccccb4cc2c32e5b5ef
Reviewed-on: https://chromium-review.googlesource.com/678061
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504814}
[modify] https://crrev.com/4c43d568f440a09f116b23cafd8ba065021b0ff2/ash/system/tray/actionable_view.cc
[modify] https://crrev.com/4c43d568f440a09f116b23cafd8ba065021b0ff2/ash/system/tray/actionable_view.h
[modify] https://crrev.com/4c43d568f440a09f116b23cafd8ba065021b0ff2/ash/system/tray/tray_item_more.cc
[modify] https://crrev.com/4c43d568f440a09f116b23cafd8ba065021b0ff2/ash/system/tray/tray_item_more.h
[modify] https://crrev.com/4c43d568f440a09f116b23cafd8ba065021b0ff2/ui/views/controls/button/button.cc
[modify] https://crrev.com/4c43d568f440a09f116b23cafd8ba065021b0ff2/ui/views/controls/button/button.h

Status: Fixed (was: Assigned)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment