New issue
Advanced search Search tips

Issue 747463 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WARN_UNUSED_RESULT should specify _Check_return_ for MSVC

Project Member Reported by erikc...@chromium.org, Jul 21 2017

Issue description

This CL [despite the name] turns it on for clang: https://codereview.chromium.org/1390223002/

We should also turn it on for MSVC.
 

Comment 1 by dcheng@chromium.org, Jul 21 2017

To clarify, it was already on for clang on posix (since clang tries to imitate gcc there). That CL made it work on win clang as well.

Comment 2 by thakis@chromium.org, Jul 21 2017

Meh, we're switching to clang on win in m62, and in that config WARN_UNUSED_RESULT already does something.

Comment 3 by jsc...@chromium.org, Jul 21 2017

Status: WontFix (was: Untriaged)
I meh'd on another thread for the same reasons, so I think it's fine to WontFix.

However, I'll open a bug on moving to the C++17 [[nodiscard]] attribute, since that will eventually be the proper solution and it should work everywhere.

Sign in to add a comment