WARN_UNUSED_RESULT should specify _Check_return_ for MSVC |
||
Issue descriptionThis CL [despite the name] turns it on for clang: https://codereview.chromium.org/1390223002/ We should also turn it on for MSVC.
,
Jul 21 2017
Meh, we're switching to clang on win in m62, and in that config WARN_UNUSED_RESULT already does something.
,
Jul 21 2017
I meh'd on another thread for the same reasons, so I think it's fine to WontFix. However, I'll open a bug on moving to the C++17 [[nodiscard]] attribute, since that will eventually be the proper solution and it should work everywhere. |
||
►
Sign in to add a comment |
||
Comment 1 by dcheng@chromium.org
, Jul 21 2017