These tests are running fine with iPhone 5s/iOS 11.0 on Xcode9 beta 4 locally.

Yuke:  I'm marking this bug as Won't Fix. Please verify, thanks!

Re-produced locally.

These tests fail due to some UI changes on the sign in page. The description when a user signs in is now longer than one page on iPhone 5s,  which causing the missing of "OK, GOT IT" button.  The tests need to tap on "MORE" first to view the entire page.

Need to verify if we want this UI change in the product.

Thank you for looking at this Menglu!

Here are the screenshots on iOS10 and iOS11.

There is a bot more space on top of the user photo.

Deleted: SyncFakeServerTestCase_testSyncCheckDifferentCacheGuid_SignOutAndSignIn.png 76.6 KB

	SyncFakeServerTestCase_testSyncCheckDifferentCacheGuid_SignOutAndSignIn.png 76.6 KB View Download

Deleted: Screen Shot 2017-07-26 at 1.10.57 PM.png 127 KB

	Screen Shot 2017-07-26 at 1.10.57 PM.png 127 KB View Download

CC msarda to verify if there is the correct behavior.

CC +Jerome who is now the eng for Chrome iOS sign-in and is now working earl grey tests.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffb2839dd090739c2681be44b62e00420974de57

commit ffb2839dd090739c2681be44b62e00420974de57
Author: Menglu Huang <huangml@chromium.org>
Date: Thu Jul 27 23:49:40 2017

Disable SyncFakeServerTests on iOS11 due to a sign-in bug.

Bug:  747445 
Change-Id: I92ab9830cde0d0546bedd6839f166ef4f1397a0d
Reviewed-on: https://chromium-review.googlesource.com/587340
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490133}
[modify] https://crrev.com/ffb2839dd090739c2681be44b62e00420974de57/ios/chrome/browser/ui/sync/sync_fake_server_egtest.mm

Hi Jerome, can you verify if we want this UI change in product? If so, I can modify the tests.  

Assign the bug to jlebel@ to verify.

So it looks like for some reason the UI takes more space on iOS 11 beta 4. I still can't reproduce it (but working on it).
The scrollview behaves correctly since the "MORE" button is changed into "OK GOT IT" as soon the user scrolls down.

The fast and bad solution would be to add a scroll down event in the tests before trying to tap the "OK GOT IT". But there is no reason to have different behaviour between iOS 10 and iOS 11 since everything is the same.

I will find a way to solve this scroll issue (so the user doesn't have to scroll down), as soon as I can reproduce this bug on my side.  

Thanks for the update Jerome!

I just sync-ed the code and tried to see if I can reproduce.  I can still see the problem.  I used xcode9 beta4,  built chrome on iPhone 5s simulators(The UI difference only happens on smaller phones, e.g. iphone 5s) and signed in my account. The "More" button happens.  

However,  if I "undo" the sign-in page and try sign-in again,  the page shows the "OK got it" button.  Here are the screenshots.

Maybe try resetting the simulators?

Deleted: sign_in_page_first_time.png 61.9 KB

	sign_in_page_first_time.png 61.9 KB View Download

Deleted: sign_in_page_after_undo.png 56.8 KB

	sign_in_page_after_undo.png 56.8 KB View Download

After a clean&rebuild, I can reproduce it.

On iOS 10 with iPhone 5, the header is 170 points instead of 190. Because of that, everything fits in the screen, so the bottom right button is "OK, GOT IT". If it was 190 (like on iOS 11), the button would be "MORE".

I still don't know if it is a feature or bug. But the consequence is the user icon is too high and it part of the status bar. So it looks like the bug was for iOS 10/iphone 5, and not for iOS 11/iPhone 5 (even if it was nicer for english version only).

So unless a UX would tell me otherwise, I'm thinking to fix it on iOS 10 (to look like iOS 11) and update the tests to not fails.

Mihai might have an idea about that issue (he will be back tomorrow).

Thanks for the update jlebel@, let's wait for Mihai to weigh in, so assigning the bug to him for now.

CC+ ewald@

I think that it would be better to avoid presenting the more button if possible. One possibility would be to shrink the space between the account image and the title ("Hi, Menglu .."), which is today 24 pixels.
Eli: Let's discuss this change during our next 1:1 or during our next weekly meeting.

Sure, we can chat about this during our 1:1, but the general presence of the MORE button is a feature not a bug. Even if we do something that works for English, that wouldn't guarantee that it wouldn't be shown for all languages.

My preference would be to do what Jerome described: fix the bug in iOS 10 that caused the header to be too small, so that the more button is consistently shown across all OSes.

Jerome: Let's go with Eli's suggestion then (that the users will see the More button on small screen devices).

Thanks for the updates! Just to make sure, have we reached the conclusion that we want to keep the "More" button and update the tests?

Yes.

This is another issue that has the same root cause:
https://bugs.chromium.org/p/chromium/issues/detail?id=751846

I'll update the tests to re-enable them, we have tests across different places that are affected, so I'm assigning it to myself to write a common helper.

Right now, to re-enable those tests, I still need to add an if condition and only tap on "More" button on iOS 11, to whoever is going to work on fixing the issue on iOS 10, do we have an ETA for this?

Unfortunately, I can't promise any ETA right now.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3598f83b33f2f7e52ef813283b9fa655c6b0091c

commit 3598f83b33f2f7e52ef813283b9fa655c6b0091c
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Aug 10 17:06:16 2017

Fix and re-enable SyncFakeServerTestCase on iOS 11.

These tests fail due to some UI changes on the sign in page. The 
description when a user signs in is now longer than one page on 
iPhone 5s,  which is causing the missing of "OK, GOT IT" button.
The tests need to scroll down first to dismiss the "MORE" button and 
make the "OK, GOT IT" button visible before tapping.

This CL fixes and re-enables the failing tests in 
SyncFakeServerTestCase by using the common helper sign in methods in
chrome_earl_grey_ui, which already handles the scrolling.

Bug:  747445 
Change-Id: I864160f540915d3021dbf4390be7a2359e0fded9
Reviewed-on: https://chromium-review.googlesource.com/604383
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493434}
[modify] https://crrev.com/3598f83b33f2f7e52ef813283b9fa655c6b0091c/ios/chrome/browser/ui/sync/sync_fake_server_egtest.mm