ProgressIndicatorTestCase Fails on Xcode9/iOS 11, and iOS 10 iPhone 6 Plus |
|||||||||||
Issue descriptionThis test fails consistently when running locally on Xcode9/iOS 11, should investigate why it fails and re-assign or come up with a fix if possible.
,
Jul 27 2017
on Xcode beta 4, iPhone 5s, iOS 11, this test succeeds when running individually, however, fails when running the whole test case. Looks like it's not a test framework issue, maybe we didn't clean things up in tear down?
,
Jul 28 2017
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95945206b7719b696681b885940e776fd574fa29 commit 95945206b7719b696681b885940e776fd574fa29 Author: Yuke Liao <liaoyuke@chromium.org> Date: Fri Jul 28 18:48:21 2017 Disable two tests in ProgressIndicatorTestCase. testProgressIndicatorShownOnFormSubmit and testProgressIndicatorDisappearsAfterFormSubmit succeed when running individually, however, fail when run the whole test suite, so doesn't look like a test framework bug, maybe we didn't clean up? Has assigned to michaeldo@ for investigation. Bug: 747442 Change-Id: Ie853867176da8213b59b07a4e182871c6e60e9de Reviewed-on: https://chromium-review.googlesource.com/592157 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#490476} [modify] https://crrev.com/95945206b7719b696681b885940e776fd574fa29/ios/chrome/browser/web/progress_indicator_egtest.mm
,
Jul 31 2017
PINT Michael, do you mind taking a quick look ASAP just to understand the issue and make sure it's not a serious breakage in our product?
,
Jul 31 2017
I thought this was due to not cancelling the infinite loads, but trying to add code to stop the load before the end of the tests that load infinitely did not fix this. I'm also not sure why that would only cause an issue on iOS11. Sending to Ed as test author.
,
Aug 1 2017
Ed, could you please take a look ASAP? This test belongs to the web_egtest suite, if you simply converted this test, could you please reach out to Eugene to find out who owns this test?
,
Aug 2 2017
PING Ed, any update? and are you the right person to handle this issue? Note that ProgressIndicatorTestCase/testProgressIndicatorShownOnFormSubmit also fails on iOS 10, iPhone 6 Plus, and it always fails on the first run, though succeeds on re-trying: https://uberchromegw.corp.google.com/i/internal.bling.fyi/builders/EarlGrey-simulator/builds/8966, so looks like this is not an issue specifically related to iOS 11. More examples: https://uberchromegw.corp.google.com/i/internal.bling.fyi/builders/EarlGrey-simulator/builds/8965 https://uberchromegw.corp.google.com/i/internal.bling.fyi/builders/EarlGrey-simulator/builds/8964
,
Aug 7 2017
This test also fails on iOS 10, not specifically related to iOS 11, so removing the RBB labels. However, we still want this to be fixed.
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/186e02b37de802510aa7bf1b16da33dc1075b9ac commit 186e02b37de802510aa7bf1b16da33dc1075b9ac Author: Yuke Liao <liaoyuke@chromium.org> Date: Tue Aug 08 16:22:20 2017 Re-enable tests in ProgressIndicatorTestCase on iOS 11. These tests are already failing on iOS 10, so not an issue specifically related to iOS 11. Bug: 747442 Change-Id: Ied3e4f104c5eb433f86045f67f0de79cc5fc1f76 Reviewed-on: https://chromium-review.googlesource.com/604766 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#492648} [modify] https://crrev.com/186e02b37de802510aa7bf1b16da33dc1075b9ac/ios/chrome/browser/web/progress_indicator_egtest.mm
,
Aug 15 2017
,
Sep 14 2017
Is this bug fixed per comment #10?
,
Sep 15 2017
No, it's still flaky. It was first disabled on iOS 11 due to flakiness, but then I fond out that it's also flaky on iOS 10, so I enabled it on iOS 11 because it's not an issue specifically related to iOS 11.
,
Jan 24 2018
,
Jan 24 2018
,
Apr 6 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by liaoyuke@chromium.org
, Jul 21 2017