New issue
Advanced search Search tips

Issue 747438 link

Starred by 0 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

can't get to old builds of official builders

Project Member Reported by ojan@chromium.org, Jul 21 2017

Issue description

https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/

Normally this page has a link you can click to show 200 builds. This bot doesn't upload to test-results and there's no UI for seeing older builds to see when a failure started. I can manually go backwards with modifying the URL, but that's extremely inefficient.
 
Owner: seanmccullough@chromium.org
Status: Started (was: Untriaged)
I believe we aren't really crawling those builds very well (make some incorrect assumptions about how to extract the version/branch etc in some cases), so we'll fix that first.  

Then we'll need to add official.desktop etc to the analyzer cron jobs in order to actually generate alerts (we don't currently). 

Should official.desktop.continuous alerts be combined with the existing Chromium alerts view? I'm a little unclear how failures on official affect sheriffs.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ba9959b822a8f996a8d7b708a710ab31b51540e9

commit ba9959b822a8f996a8d7b708a710ab31b51540e9
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Thu Jul 27 20:43:39 2017

[som] official: try to parse version from chrome_version build prop

This is a fallback for if there is no Configure step, sometimes there
appears to be a chrome_version build property set by buildbucket that
has this same version value.

e.g. https://uberchromegw.corp.google.com/i/official.desktop/builders/win-asan/builds/704

The bug where the Configure step parsing was introduced gives some
more context:
https://bugs.chromium.org/p/chromium/issues/detail?id=617839

TL;DR is that official builders are weird and run different *branches*
on the same builder. So we have to group failures by their version
(=branch?) before analyzing the sequence of step outputs.

Bug:747438
Change-Id: Ife7f3e3c776e5d498eb52a7a407626bc397ac884
Reviewed-on: https://chromium-review.googlesource.com/588115
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Di Mu <dimu@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>

[modify] https://crrev.com/ba9959b822a8f996a8d7b708a710ab31b51540e9/go/src/infra/monitoring/analyzer/official.go
[modify] https://crrev.com/ba9959b822a8f996a8d7b708a710ab31b51540e9/go/src/infra/monitoring/analyzer/official_test.go
[modify] https://crrev.com/ba9959b822a8f996a8d7b708a710ab31b51540e9/go/src/infra/monitoring/analyzer/analyzer.go

Labels: Milestone-Workflow
Note from mmoss@: The official *continuous* builders don't build multiple branches per builder, so we can prioritize getting official continuous builders into SoM ahead of getting official release builders into it. The latter will require more analyzer and UI code changes to handle properly.
Labels: Type-Feature

Sign in to add a comment