New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747437 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 747114



Sign in to add a comment

JSPrintTestCase Fails on Xcode9/iOS 11

Project Member Reported by liaoyuke@chromium.org, Jul 21 2017

Issue description

This test fails consistently when running locally on Xcode9/iOS 11, should investigate why it fails and re-assign or come up with a fix if possible.
 
Blocking: 747114
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd1bd6678c491e355f9e0f1f67ec15e45919aaf0

commit cd1bd6678c491e355f9e0f1f67ec15e45919aaf0
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Jul 27 23:45:35 2017

Fix testWebPrintButton on iOS 11

Background: the printer view comes from Apple for free, so we don't
have control over the accessibility ids or labels of the elements.

This test breaks on iOS 11 because Apple has changed the attributes
of the "Printer Options" navigation bar and "Cancel" button, and this
CL fixes the test by updating the matchers so that they work on both
iOS 10 and iOS 11.

Bug:  747437 
Change-Id: I76f5077799f19700f8476ee6bba8c39f66952255
Reviewed-on: https://chromium-review.googlesource.com/588010
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490126}
[modify] https://crrev.com/cd1bd6678c491e355f9e0f1f67ec15e45919aaf0/ios/chrome/browser/web/js_print_egtest.mm

Status: Fixed (was: Available)

Sign in to add a comment