BrowsingPreventDefaultTestCase Fails on Xcode9/iOS 11 |
||||||
Issue descriptionThis test fails consistently when running locally on Xcode9/iOS 11, should investigate why it fails and re-assign or come up with a fix if possible.
,
Jul 27 2017
Disabled line in failing test here: https://chromium-review.googlesource.com/c/589708/ eugenebut@ it's possible this line isn't needed. If it is needed this needs more eyes from the EG perspective. Can you take a look first on the webglue side? If it's needed, can you flip to yuke for more investigation? thanks!
,
Jul 27 2017
|[ChromeEarlGrey waitForWebViewContainingText:"Click done"];| line is needed. This code wait's until the page is changed after the click.
,
Jul 27 2017
Just to make sure we're on the same page: this test displays "Click done" and then automatically redirects to a blank page, and it fails on iOS 11 because the redirect happened too fast, even before |[ChromeEarlGrey waitForWebViewContainingText:"Click done"];| is called. In this case, I don't it's a test framework's issue, and if we still want to keep |[ChromeEarlGrey waitForWebViewContainingText:"Click done"];| in the test, we need to make sure 1. chrome_test_util::TapWebViewElementWithId(linkID); 2. [ChromeEarlGrey waitForWebViewContainingText:"Click done"]; executes atomically, WDYT?
,
Jul 27 2017
Thanks for explanation. If we want to keep |[ChromeEarlGrey waitForWebViewContainingText:"Click done"];| then we can change the page to send XHR to a server. Or maybe |waitForWebViewContainingText:"Click done"| is not that important?
,
Jul 27 2017
I think you or someone knows more about this test should make the decision, so I'm assigning the bug to you. Feel free to re-assign if you think there is anything I can help.
,
Jul 27 2017
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b23111c75be2f84dcfa0ce80e43bf8d586f923a6 commit b23111c75be2f84dcfa0ce80e43bf8d586f923a6 Author: Justin Cohen <justincohen@google.com> Date: Thu Jul 27 23:14:18 2017 Disable portion of failing testPreventDefaultOverridesWindowOpen test on iOS11. It seems like the text 'Click done' isn't visible long enough on iOS11. It's possible this is an issue in Earl Grey, iOS11, or just the extra text check is unnecessary. Bug: 747434 Change-Id: Iff5c82b77a58285352d47d75c7a5a29dfdea3251 Reviewed-on: https://chromium-review.googlesource.com/589708 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#490076} [modify] https://crrev.com/b23111c75be2f84dcfa0ce80e43bf8d586f923a6/ios/chrome/browser/web/browsing_prevent_default_egtest.mm
,
Jul 28 2017
Removing RBB, because test does not fail anymore.
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60925b5a56a1fe5a252316267f103ddeca5c8ac7 commit 60925b5a56a1fe5a252316267f103ddeca5c8ac7 Author: Eugene But <eugenebut@google.com> Date: Fri Jul 28 19:07:01 2017 Cleaned up BrowsingPreventDefaultTestCase. Notables changes: - cleaned up unused HTML - renamed link ids to match Style Guide - use tapWebViewElementWithID for tapping the link (this way there is no need to wait for "Click done" web view text) Bug: 747434 Change-Id: Icc44783d4611785074a8f2655ea9a1cb1e13c1c9 Reviewed-on: https://chromium-review.googlesource.com/591990 Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#490482} [modify] https://crrev.com/60925b5a56a1fe5a252316267f103ddeca5c8ac7/ios/chrome/browser/web/browsing_prevent_default_egtest.mm [modify] https://crrev.com/60925b5a56a1fe5a252316267f103ddeca5c8ac7/ios/testing/data/http_server_files/browsing_prevent_default_test_page.html
,
Jul 28 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by liaoyuke@chromium.org
, Jul 21 2017