New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747431 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocked on:
issue 748163

Blocking:
issue 747114



Sign in to add a comment

AutofillSettingsTestCase Fails on Xcode9/iOS 11

Project Member Reported by liaoyuke@chromium.org, Jul 21 2017

Issue description

This test fails consistently when running locally on Xcode9/iOS 11, should investigate why it fails and re-assign or come up with a fix if possible.
 
Blocking: 747114
Blockedon: 748163
Labels: ReleaseBlock-Beta M-62
Owner: mahmadi@chromium.org
Status: Assigned (was: Available)
I'm disabling this test, please refer to  issue 748163  for more info why it fails.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78c9547d9a5a40619a4225d034872a82c3175232

commit 78c9547d9a5a40619a4225d034872a82c3175232
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Jul 25 18:36:24 2017

Disable testAutofillProfileEditing on iOS 11.

testAutofillProfileEditing fails consistently on Xcode9 beta4/ iOS11,
and this CL disables it on iOS11 to unblock putting other tests onto
iOS 11 bot.

Bug:  747431 
Change-Id: I4dec2ab5a135eb20fb5f0f2c37c0044f8c013e5e
Reviewed-on: https://chromium-review.googlesource.com/585213
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489384}
[modify] https://crrev.com/78c9547d9a5a40619a4225d034872a82c3175232/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm

Owner: liaoyuke@chromium.org
blocked on  issue 748163 , and actually, nothing is wrong with the test, once the product bug is fixed, we can re-enable this test.
This test succeeds on beta 5, looks like Apple fixed the issue, I can only verify it works when both build and test with beta 5. Just spoke to Justin, we should be able to have our bots build with beta 5 next week, and it may take long to update our testers.

I will give it try when we can build with beta 5, and decide what to do then.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03bbf72bf0b90103dd7f016f378de5e373a7892f

commit 03bbf72bf0b90103dd7f016f378de5e373a7892f
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Aug 15 18:38:23 2017

Refactoring testAutofillProfileEditing.

This test used to take 3 minutes to run because it repeately
"Select all and cut" to clear the text field, which is not only slow
but unnecessary.

This CLs re-factors the test to use grey_replaceText instead of
grey_typeText and removes the "clear text" step, and now it takes about
only 20 seconds to run.

Bug:  747431 
Change-Id: Ida219f98bc5397dd851413098a07af07d8af3c80
Reviewed-on: https://chromium-review.googlesource.com/612128
Reviewed-by: mahmadi (Moe) <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494461}
[modify] https://crrev.com/03bbf72bf0b90103dd7f016f378de5e373a7892f/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment