Issue metadata
Sign in to add a comment
|
HttpServerPropertiesManagerTests flaky crash on Cast Linux bot |
||||||||||||||||||||||
Issue descriptionLooks like the patch that caused this was reverted (https://chromium-review.googlesource.com/c/575311/) and relanded (https://chromium-review.googlesource.com/c/576349/) without the flake being fix. https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/42446 https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/42445 HttpServerPropertiesManagerTest.UpdateCacheWithPrefs/2 HttpServerPropertiesManagerTest.UpdateCacheWithPrefs/1 HttpServerPropertiesManagerTest.UpdateCacheWithPrefs/0 HttpServerPropertiesManagerTest.UpdatePrefsWithCache/2 HttpServerPropertiesManagerTest.UpdatePrefsWithCache/1 HttpServerPropertiesManagerTest.UpdatePrefsWithCache/0 HttpServerPropertiesManagerTest.DoNotPersistExpiredAlternativeService/0 HttpServerPropertiesManagerTest.DoNotPersistExpiredAlternativeService/1 HttpServerPropertiesManagerTest.DoNotPersistExpiredAlternativeService/2 Here's one stack trace: Received signal 11 SEGV_MAPERR 000000000008 #0 0x000002606b07 base::debug::StackTrace::StackTrace() #1 0x00000260667f base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f2869369340 <unknown> #3 0x00000265eecb base::internal::flat_tree<>::lower_bound() #4 0x00000265d7e8 base::flat_map<>::operator[]() #5 0x00000265d3c5 base::DictionaryValue::SetWithoutPathExpansion() #6 0x00000265db0f base::DictionaryValue::SetStringWithoutPathExpansion() #7 0x000002465cca net::HttpServerPropertiesManager::SaveBrokenAlternativeServicesToPrefs() #8 0x0000024652af net::HttpServerPropertiesManager::UpdatePrefsOnPrefThread() #9 0x000002466e5c _ZN4base8internal13FunctorTraitsIMN3net27HttpServerPropertiesManagerEFvNSt3__110unique_ptrINS4_6vectorINS4_12basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEENSA_ISC_EEEENS4_14default_deleteISE_EEEENS5_INS_8MRUCacheIN3url14SchemeHostPortENS6_INS2_22AlternativeServiceInfoENSA_ISL_EEEENS4_4lessISK_EEEENSF_ISQ_EEEENS5_INS2_9IPAddressENSF_IST_EEEENS5_INSI_ISK_NS2_18ServerNetworkStatsESP_EENSF_ISX_EEEENS5_INSI_INS2_12QuicServerIdESC_NSO_IS10_EEEENSF_IS12_EEEENS5_INS4_4listINS4_4pairINS2_18AlternativeServiceENS_9TimeTicksEEENSA_IS19_EEEENSF_IS1B_EEEENS5_INSI_IS17_iNSO_IS17_EEEENSF_IS1F_EEEERKNS_8CallbackIFvvELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEEvE6InvokeIRKNS_7WeakPtrIS3_EEJSH_SS_SV_SZ_S14_S1D_S1H_S1O_EEEvS1Q_OT_DpOT0_ #10 0x000002466bfa _ZN4base8internal7InvokerINS0_9BindStateIMN3net27HttpServerPropertiesManagerEFvNSt3__110unique_ptrINS5_6vectorINS5_12basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEENSB_ISD_EEEENS5_14default_deleteISF_EEEENS6_INS_8MRUCacheIN3url14SchemeHostPortENS7_INS3_22AlternativeServiceInfoENSB_ISM_EEEENS5_4lessISL_EEEENSG_ISR_EEEENS6_INS3_9IPAddressENSG_ISU_EEEENS6_INSJ_ISL_NS3_18ServerNetworkStatsESQ_EENSG_ISY_EEEENS6_INSJ_INS3_12QuicServerIdESD_NSP_IS11_EEEENSG_IS13_EEEENS6_INS5_4listINS5_4pairINS3_18AlternativeServiceENS_9TimeTicksEEENSB_IS1A_EEEENSG_IS1C_EEEENS6_INSJ_IS18_iNSP_IS18_EEEENSG_IS1G_EEEERKNS_8CallbackIFvvELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEEJNS_7WeakPtrIS4_EENS0_13PassedWrapperISI_EENS1U_IST_EENS1U_ISW_EENS1U_IS10_EENS1U_IS15_EENS1U_IS1E_EENS1U_IS1I_EES1N_EEES1K_E7RunImplIRKS1R_RKNS5_5tupleIJS1T_S1V_S1W_S1X_S1Y_S1Z_S20_S21_S1N_EEEJLm0ELm1ELm2ELm3ELm4ELm5ELm6ELm7ELm8EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #11 0x00000289e4a9 base::TestMockTimeTaskRunner::ProcessAllTasksNoLaterThan() #12 0x000000dd7126 net::HttpServerPropertiesManagerTest_UpdateCacheWithPrefs_Test::TestBody() #13 0x000001d1fa96 testing::Test::Run() #14 0x000001d20520 testing::TestInfo::Run() #15 0x000001d20a07 testing::TestCase::Run() #16 0x000001d26cb7 testing::internal::UnitTestImpl::RunAllTests() #17 0x000001d26943 testing::UnitTest::Run() #18 0x00000289f7e4 base::TestSuite::Run() #19 0x0000028a13aa base::(anonymous namespace)::LaunchUnitTestsInternal() #20 0x0000028a126a base::LaunchUnitTests() #21 0x00000191f832 main #22 0x7f2868fb5ec5 __libc_start_main #23 0x0000005c3870 <unknown> r8: 000000000000000a r9: 00000000000001bb r10: 00000000596d83bd r11: 0000000000000006 r12: 0000000002cb6ac9 r13: 00007fff159cdc11 r14: 00007fff159cdc10 r15: 0000000000000008 di: 0000000000000008 si: 00007fff159cdc10 bp: 0000000002cb6ac9 bx: 000000000000000c dx: 000000000000000c ax: 00007fff159cdc11 cx: 0000000000000018 sp: 00007fff159cdb90 ip: 000000000265eecb efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000004 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000008 [end of stack trace]
,
Jul 21 2017
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/756d947a35e25732ad9c58f47683dafbddfe32fd commit 756d947a35e25732ad9c58f47683dafbddfe32fd Author: Ojan Vafai <ojan@chromium.org> Date: Fri Jul 21 18:56:41 2017 Revert "Reland "Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager""" This reverts commit 724ac890c910d8633ef1428f0f38a222a6d4eb2a. Reason for revert: Still flakes net_unittests on some bots. BUG= 747424 , 705029 Original change's description: > Reland "Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager"" > > This is a reland of 9c0837065ee0522dc05b2908a6815c25146ad1b2 > Original change's description: > > Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager" > > > > This is a reland of a66ebc8af26cdad325746d9d5644169a16996821 > > Original change's description: > > > Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager > > > > > > Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param. > > > Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing. > > > > > > Add BrokenAlternativeService::Clear() and update HttpServerPropertiesImpl::Clear() to call that. > > > > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > > > > > > BUG= 705029 > > > > > > Change-Id: Idb411192e47d275cde3362b479a6b9e9fa773a17 > > > Reviewed-on: https://chromium-review.googlesource.com/562604 > > > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > > > Reviewed-by: Steven Holte <holte@chromium.org> > > > Commit-Queue: Yixin Wang <wangyix@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#486519} > > > > Bug: 705029 > > Change-Id: I14f36cc6014f001d9aefa4678a7bfa8f621b2834 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > > Reviewed-on: https://chromium-review.googlesource.com/571044 > > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > > Reviewed-by: Steven Holte <holte@chromium.org> > > Commit-Queue: Yixin Wang <wangyix@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#487342} > > Bug: 705029 > Change-Id: Iefb798a8c4d54263e5e8f47bc5d1c63c04d72f77 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/576349 > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Commit-Queue: Yixin Wang <wangyix@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487990} TBR=mpearson@chromium.org,rch@chromium.org,zhongyi@chromium.org,wangyix@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 705029 Change-Id: Icadb2cc56c2e83f2dfdf5dfb327c5d0544bad3d3 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/581627 Reviewed-by: Ojan Vafai <ojan@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488724} [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/net/http/broken_alternative_services.cc [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/net/http/broken_alternative_services.h [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/net/http/http_server_properties.h [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/net/http/http_server_properties_impl.cc [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/net/http/http_server_properties_impl.h [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/net/http/http_server_properties_manager.cc [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/net/http/http_server_properties_manager.h [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/net/http/http_server_properties_manager_unittest.cc [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/tools/metrics/histograms/histograms.xml
,
Nov 13 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ojan@chromium.org
, Jul 21 2017