Both of these access ozone state, which ash should not be doing.
Actually, InputDeviceManager is wired correctly in mus/mash. In mus/mash InputDeviceManager is an InputDeviceClient. DeviceDataManager isn't used in ash code (outside of tests), so there is nothing to do here.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5417ebd934543441aede65081c556357968ef72c commit 5417ebd934543441aede65081c556357968ef72c Author: Scott Violet <sky@chromium.org> Date: Sun Jul 23 20:02:59 2017 chromeos: tightens DEPS for ui/events/devices Parts of ui/events/devices are specific to the process hosing ozone (mus) and ash should not be using them directly. This patch adds deps for DeviceDataManager or InputDeviceManager, but they are temporary. Also removes some stale includes. BUG= 747415 TEST=none Change-Id: If54455c113f1545e2a3f58b24b1a0646a051f454 Reviewed-on: https://chromium-review.googlesource.com/581391 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#488891} [modify] https://crrev.com/5417ebd934543441aede65081c556357968ef72c/ash/DEPS [modify] https://crrev.com/5417ebd934543441aede65081c556357968ef72c/ash/host/DEPS [modify] https://crrev.com/5417ebd934543441aede65081c556357968ef72c/ash/root_window_controller_unittest.cc [modify] https://crrev.com/5417ebd934543441aede65081c556357968ef72c/ash/system/status_area_widget.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b840aa23c0d85adeadb283a6d41108015756d5f7 commit b840aa23c0d85adeadb283a6d41108015756d5f7 Author: James Cook <jamescook@chromium.org> Date: Thu Oct 26 19:40:29 2017 cros: Fix ash_unittests --mus for TrayIME and VirtualKeyboardController They were using ui::DeviceDataManager, which does not exist in mus. Switch tests to use ui::InputDeviceManager and add test support methods. I can't add an InputDeviceManagerTestApi because there are two different concrete implementations. Tighten DEPS restrictions for DeviceDataManager. Bug: 745005, 747415 Test: ash_unittests --mus Change-Id: Ia3e250218888bda7f45d199575852979a568ad2c Reviewed-on: https://chromium-review.googlesource.com/738850 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#511926} [modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/ash/DEPS [modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/ash/display/DEPS [modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/ash/system/ime/tray_ime_chromeos_unittest.cc [modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/ash/virtual_keyboard_controller_unittest.cc [modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/services/ui/public/cpp/input_devices/input_device_client.cc [modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/services/ui/public/cpp/input_devices/input_device_client.h [modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/testing/buildbot/filters/ash_unittests_mash.filter [modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/testing/buildbot/filters/ash_unittests_mus.filter [modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/ui/events/devices/device_data_manager.cc [modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/ui/events/devices/device_data_manager.h [modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/ui/events/devices/input_device_manager.h
Comment 1 by sky@chromium.org
, Jul 21 2017