Issue metadata
Sign in to add a comment
|
Mobile Bookmarks label is truncated when device is in RTL(HE) |
||||||||||||||||||||||
Issue descriptionApp Version: 61.0.3162.0 Canary iOS Version: 10.3.2, 11.0 Device: iPhone URL: Precondition: Settings -> General -> Language & Region -> iPhone Language -> Hebrew Steps to reproduce: 1. Launch app 2. Go to Menu -> Bookmarks 3. Tap on the menu button on the top right Observed results: Mobile Bookmarks label is truncated when device is in RTL(HE) Expected results: Mobile Bookmarks label should not be truncated when device is in RTL(HE) Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not Tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No -M59 Bug reproducible on the current beta channel build (App Version, iOS Version):No -M60 Image: M61: https://drive.google.com/a/google.com/file/d/0B3EcbqLuR5TLMVNzS2JwOHllaWs/view M59: https://drive.google.com/a/google.com/file/d/0B3EcbqLuR5TLUE9RX25HWkhGZ3c/view
,
Jul 25 2017
,
Jul 25 2017
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d5b4955c30c125215be6ea62e632ad8e567865d commit 8d5b4955c30c125215be6ea62e632ad8e567865d Author: Ramya Sharma <ramyasharma@chromium.org> Date: Tue Jul 25 16:07:22 2017 Fixes the frame of the menu view so that it is not truncated in RTL. The menuview frame must be set equal to the panelview's menuwrapper bounds on iPhone. This was missed during refactoring classes to pull out logic to the super class. This did not effect LTR languages but manifests as a bug in RTL. Bug: 747411 , 747410 Change-Id: Id1ac76153f3c12f9430f42460bf17e5de86c01fe Reviewed-on: https://chromium-review.googlesource.com/583879 Reviewed-by: Jean-François Geyelin <jif@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#489323} [modify] https://crrev.com/8d5b4955c30c125215be6ea62e632ad8e567865d/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm
,
Jul 26 2017
,
Jul 26 2017
Requesting merge to M61 as this is a regression.
,
Jul 26 2017
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ade4b378d35330c4b10a50cbe3b4fb576455636b commit ade4b378d35330c4b10a50cbe3b4fb576455636b Author: ramyasharma@chromium.org <ramyasharma@chromium.org> Date: Thu Jul 27 01:30:10 2017 Fixes the frame of the menu view so that it is not truncated in RTL. The menuview frame must be set equal to the panelview's menuwrapper bounds on iPhone. This was missed during refactoring classes to pull out logic to the super class. This did not effect LTR languages but manifests as a bug in RTL. TBR=ramyasharma@chromium.org (cherry picked from commit 8d5b4955c30c125215be6ea62e632ad8e567865d) Bug: 747411 , 747410 Change-Id: Id1ac76153f3c12f9430f42460bf17e5de86c01fe Reviewed-on: https://chromium-review.googlesource.com/583879 Reviewed-by: Jean-François Geyelin <jif@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489323} Reviewed-on: https://chromium-review.googlesource.com/587512 Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#71} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/ade4b378d35330c4b10a50cbe3b4fb576455636b/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm
,
Aug 1 2017
Verified in 62.0.3173.0 canary, iPhone 6 plus iOS 10.3.3, iPhone 7 iOS11, Looks good.
,
Aug 2 2017
Verified in 61.0.3163.25 Beta, iPhone6 plus(iOS11 beta4) and iPhone7(iOS10.3.3) Looks good. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by edchin@chromium.org
, Jul 24 2017Labels: M-61
Owner: noyau@chromium.org
Status: Assigned (was: Untriaged)