New issue
Advanced search Search tips

Issue 747409 link

Starred by 0 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

groups with 1 alert left are confusing

Project Member Reported by ojan@chromium.org, Jul 21 2017

Issue description

1. I ended up with a group that has only 1 alert. I would guess someone grouped 2 alerts together and one of them stopped firing?

2. The merged alert view didn't show any tests.

3. I'm not sure why the group UUID is shown in the UI and is editable. What can I do with it as a sheriff?

See screenshots.
 
grouping.png
69.4 KB View Download
grouping2.png
49.6 KB View Download
Thanks, feedback on grouping is super appreciate! 

1. I have noticed a lot of 1 alert groups in the Chromium tree in particular. I think your guess is probably right. We might want to consider showing recently resolved alerts that are attached to groups. Though we'd have to make it clear in the UI that those particular group members are not active anymore. 

2. Thanks for noting this! I have a bug for this here: https://bugs.chromium.org/p/chromium/issues/detail?id=723875 I want to work on this soon. 

3. The UUID is supposed to be surfaced as the name for the group and is editable to allow users to set a custom title. There is a discussion on improving the titles for alerts here: https://bugs.chromium.org/p/chromium/issues/detail?id=744755 (I plan to implement this soon. 

Comment 2 by ojan@chromium.org, Jul 21 2017

Summary: groups with 1 alert left are confusing (was: feedback on grouping)
For #1 could you just pretend it's not grouped if there's only 1 alert in the group?

Will repurpose this bug for #1 since 2 and 3 have separate bugs.
Cc: davidri...@chromium.org
Displaying groups with 1 alert similarly to a normal alert should be okay I think. 

There are some things that would be odd about it though. For example, at the moment, you can't group two groups together, so that would potentially be confusing to users. 

I think that's probably alright though. We plan to eventually implement grouping to groups together anyways. 

I think there might be some oddities around annotations. For example, if you ungrouped the lone alert group at the moment, it'd lose its annotations. For now, we could probably just hide the ungroup button for single alert groups.
One potential issue is if you create a group, add some comments (which will end up attached to the group) and you remove the other alerts, it's useful to keep the history.

chromeos and gardener tree will show recently resolved alerts in the group.  It currently treats the entire group as resolved if any alert is resolved, but I think that needs to be revisited due to the way alerts are autoresolved.
Labels: Milestone-UX
Labels: Type-Feature
Status: Available (was: Untriaged)
Labels: Milestone-Polish

Sign in to add a comment