Allow pinning a UI element by clicking on it in UI DevTools inspect mode |
|||||||||||||||
Issue descriptionWhen in the 'inspect mode' of UI DevTools, clicking on a UI element within UI that is currently being inspected should 'pin' the element. When pinned, a persistent border should be drawn around the element, and any previously-pinned element should be un-pinned (i.e., at most one UI element may be pinned at any time). Note that unlike Chrome DevTools, clicking on an element in the UI should *not* exit inspect mode.
,
Jul 21 2017
,
Jul 22 2017
,
Jul 22 2017
,
Jul 24 2017
,
Jul 24 2017
,
Jul 24 2017
,
Jul 24 2017
,
Jul 24 2017
,
Jul 24 2017
,
Jul 24 2017
,
Jul 24 2017
,
Aug 10 2017
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ed66df0d95f4d2fe3f2fb8b7bdcfee016e8dc4a commit 3ed66df0d95f4d2fe3f2fb8b7bdcfee016e8dc4a Author: Thanh Pham <thanhph@chromium.org> Date: Fri Aug 18 22:05:35 2017 Show guide lines and pin elements when user clicks on UIElement in UI DevTools while in inspection mode. This cl enables users, while in inspection mode, quickly see distances between a pinned UIElement and a hovered element. To exit inspection mode, user can click on the blue box-in-arrow or press ESC key. Guide lines' UI is tweaked to look better in --force-device-scale-factor. Change-Id: I3de056e856008401bb4b1777ee66e2f588259abf Bug: 747404 Reviewed-on: https://chromium-review.googlesource.com/582930 Commit-Queue: Thanh Pham <thanhph@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#495708} [modify] https://crrev.com/3ed66df0d95f4d2fe3f2fb8b7bdcfee016e8dc4a/components/ui_devtools/views/ui_devtools_dom_agent.cc [modify] https://crrev.com/3ed66df0d95f4d2fe3f2fb8b7bdcfee016e8dc4a/components/ui_devtools/views/ui_devtools_dom_agent.h [modify] https://crrev.com/3ed66df0d95f4d2fe3f2fb8b7bdcfee016e8dc4a/components/ui_devtools/views/ui_devtools_overlay_agent.cc [modify] https://crrev.com/3ed66df0d95f4d2fe3f2fb8b7bdcfee016e8dc4a/components/ui_devtools/views/ui_devtools_overlay_agent.h [modify] https://crrev.com/3ed66df0d95f4d2fe3f2fb8b7bdcfee016e8dc4a/components/ui_devtools/views/ui_devtools_unittest.cc
,
Aug 18 2017
,
Oct 22 2017
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by thanhph@chromium.org
, Jul 21 2017