New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747401 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

16 kb regression in resource_sizes (MonochromePublic.apk) at 488554:488554

Project Member Reported by estevenson@chromium.org, Jul 21 2017

Issue description

Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jul 21 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=747401

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=2d651436286b253393831abdcf6294c1fad2ea580d0551fe5f2f98b9d86c0e98


Bot(s) for this bug's original alert(s):

Android Builder
Cc: roc...@chromium.org
Labels: OS-Android
Owner: mek@chromium.org
Status: Assigned (was: Untriaged)
It looks to me that the size increase is expected. Created this bug to see if there's any way to reduce the size jump when support_lazy_serialization = true since presumably this will be added to more targets causing more size jumps.

Otherwise, feel free to close as "WontFix".

Thanks!

Comment 3 by mek@chromium.org, Jul 24 2017

Status: WontFix (was: Assigned)
Precisely for this reason we have to be really careful where to add lazy serialization, since it isn't really possible to avoid the size jump.
These particular bindings are only used within the same process, and potentially involve fairly large messages, so they are a prime candidate for lazy serialization, as those are exactly the circumstances where lazy serialization should have the biggest performance impact.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07793973ebc6a0bc657eee9436d0c72b99583e46

commit 07793973ebc6a0bc657eee9436d0c72b99583e46
Author: Mustaq Ahmed <mustaq@google.com>
Date: Thu Nov 02 19:18:56 2017

Remove unused 'user_gesture' bit from content::StorageQuotaParams.

This user code was removed here: crrev.com/1676203002

Bug:  747401 
Change-Id: I8fb70c2ff681622d61503be8815484fef36c28d7
Reviewed-on: https://chromium-review.googlesource.com/749309
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513578}
[modify] https://crrev.com/07793973ebc6a0bc657eee9436d0c72b99583e46/content/common/quota_messages.h
[modify] https://crrev.com/07793973ebc6a0bc657eee9436d0c72b99583e46/content/public/common/storage_quota_params.h
[modify] https://crrev.com/07793973ebc6a0bc657eee9436d0c72b99583e46/content/renderer/quota_dispatcher.cc

Yikes, the commit in #c4 have a wrong bug#.

Sign in to add a comment