Issue metadata
Sign in to add a comment
|
16 kb regression in resource_sizes (MonochromePublic.apk) at 488554:488554 |
||||||||||||||||||||
Issue descriptionCaused by "Turn on lazy serialization for leveldb service." Commit: 0129aaab4ebe9b8301ddccfcd7af81c169207de1 Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=488459 Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase
,
Jul 21 2017
It looks to me that the size increase is expected. Created this bug to see if there's any way to reduce the size jump when support_lazy_serialization = true since presumably this will be added to more targets causing more size jumps. Otherwise, feel free to close as "WontFix". Thanks!
,
Jul 24 2017
Precisely for this reason we have to be really careful where to add lazy serialization, since it isn't really possible to avoid the size jump. These particular bindings are only used within the same process, and potentially involve fairly large messages, so they are a prime candidate for lazy serialization, as those are exactly the circumstances where lazy serialization should have the biggest performance impact.
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07793973ebc6a0bc657eee9436d0c72b99583e46 commit 07793973ebc6a0bc657eee9436d0c72b99583e46 Author: Mustaq Ahmed <mustaq@google.com> Date: Thu Nov 02 19:18:56 2017 Remove unused 'user_gesture' bit from content::StorageQuotaParams. This user code was removed here: crrev.com/1676203002 Bug: 747401 Change-Id: I8fb70c2ff681622d61503be8815484fef36c28d7 Reviewed-on: https://chromium-review.googlesource.com/749309 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#513578} [modify] https://crrev.com/07793973ebc6a0bc657eee9436d0c72b99583e46/content/common/quota_messages.h [modify] https://crrev.com/07793973ebc6a0bc657eee9436d0c72b99583e46/content/public/common/storage_quota_params.h [modify] https://crrev.com/07793973ebc6a0bc657eee9436d0c72b99583e46/content/renderer/quota_dispatcher.cc
,
Nov 2 2017
Yikes, the commit in #c4 have a wrong bug#. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 21 2017