New issue
Advanced search Search tips

Issue 747399 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

Make it possible to revive discarded messages

Project Member Reported by scro...@google.com, Jul 21 2017

Issue description

In reitveld, I can do the following:
- double click on a line
- enter a comment
- click "Save"
- click "Edit"
- click "Discard"
(Comment goes away.)
- double click on the same line
The line I had previously discarded is restored!

This is helpful if I accidentally discard, or if I change my mind.

I don't seem to be able to do the same in PolyGerrit, even if I comment on the same exact word.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 21 2017

Labels: Hotlist-Google

Comment 2 by aga...@chromium.org, Jul 21 2017

Owner: aga...@chromium.org
Status: WontFix (was: Unconfirmed)
The fact that this "worked" in Rietveld was always a bug. Early in PolyGerrit's development it actually had the same bug, and so many people complained that we fixed it.

"Discard" is such a purposeful user interaction that disregarding it by preserving the user's content is not a pattern we want to perpetuate.

Comment 3 by scro...@google.com, Jul 21 2017

"Discard" may be purposeful, but occasionally I hit it on accident. Gmail gives me the option to "Undo discard" if I accidentally discard a draft email. Maybe something more like that would be better?

Sign in to add a comment