New issue
Advanced search Search tips

Issue 747395 link

Starred by 0 users
Status: Fixed
Owner:
b...@chromium.org
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

HpackDecoder3Test::SizeOfHeaders() does not correctly account for cookie size.

Project Member Reported by b...@chromium.org, Jul 21 2017 
HpackDecoder3Test::DecodeHeaderBlock has the expectation

EXPECT_EQ(handler_.header_bytes_parsed(), SizeOfHeaders(decoded_block()))

|handler_| receives cookies in crumbs as specified by HPACK.  However, SizeOfHeaders() sums up keys and values in decoded_block(), which is of type SpdyHeaderBlock and thus can have at most one "cookie" header field.  This expection therefore fails if a test has multiple cookies in it.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63df814dbed7f6955f7cd760c7e6a86fc6945f94

commit 63df814dbed7f6955f7cd760c7e6a86fc6945f94
Author: Dianna Hu <diannahu@chromium.org>
Date: Mon Jul 24 17:27:52 2017

Fix HpackDecoderAdapterTest::SizeOfHeaders().

Change the method to account for cookie size in crumbs form.

This CL lands server change 162751776 by bnc.

BUG=488484,  747395 

Change-Id: I453b46e4b45fe11447414037b54b7ac20d6c95aa
Reviewed-on: https://chromium-review.googlesource.com/581711
Commit-Queue: Dianna Hu <diannahu@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489011}
[modify] https://crrev.com/63df814dbed7f6955f7cd760c7e6a86fc6945f94/net/spdy/core/hpack/hpack_decoder_adapter_test.cc

Comment 2 by b...@chromium.org, Jul 25 2017

Status: Fixed (was: Started)
►

Sign in to add a comment