New issue
Advanced search Search tips

Issue 747393 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Incorrect parsing of $GTK_MODULES prevents accessibility initialization

Reported by gianlu...@opera.com, Jul 21 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.50 Safari/537.36 OPR/47.0.2631.28 (Edition beta)

Steps to reproduce the problem:
In ui/accessibility/platform/atk_util_auralinux.cc, the AtkUtilAuraLinux::Initialize function checks whether accessibility should be enabled. To do so, it calls PlatformShouldEnableAccessibility, which parses the content of the environment variable GTK_MODULES. This variable contains a list of colon-separated modules; the function parses it as it were a whitespace-separated list, looking for a module called `gail:atk-bridge`, while in fact, the module to look for is `atk-bridge`. On systems having a more complex content for GTK_MODULES (mine is `gail:atk-bridge:unity-gtk-module`), the parse fails, and the initialization aborts.

What is the expected behavior?

What went wrong?
Currently, the process is looking for the wrong value of the module name, and parsing it wrongly.

Did this work before? N/A 

Chrome version: 60.0.3112.50  Channel: stable
OS Version: 
Flash Version: Shockwave Flash 26.0 r0
 

Comment 1 by gianlu...@opera.com, Jul 21 2017

As it happens :) I have a small patch for this that I intend to propose for integration.
Labels: TE-NeedsTriageHelp
The issue seems to be out of TE-scope. Hence, adding label TE-NeedsTriageHelp for further investigation.

Thanks...!!

Comment 3 by ajha@chromium.org, Jul 24 2017

Components: -UI UI>Accessibility
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1aa2ba4b28423627d20d96f94c807ca259551907

commit 1aa2ba4b28423627d20d96f94c807ca259551907
Author: Gianluca Ciccarelli <gianlucac@opera.com>
Date: Mon Jul 24 17:50:10 2017

Fix parsing of $GTK_MODULES

The AtkUtilAuraLinux::Initialize function checks whether accessibility
should be enabled. To do so, it calls PlatformShouldEnableAccessibility,
which parses the content of the environment variable GTK_MODULES. This
variable contains a list of colon-separated modules; the function parses
it as it were a whitespace-separated list, looking for a module called
`gail:atk-bridge`, while in fact, the module to look for is
`atk-bridge`. On systems having a more complex content for GTK_MODULES
(mine is `gail:atk-bridge:unity-gtk-module`), the parse fails, and the
initialization aborts.

Bug:  747393 
Change-Id: I17d82331af1d117d0ed70520b4367c5915037316
Reviewed-on: https://chromium-review.googlesource.com/582807
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489022}
[modify] https://crrev.com/1aa2ba4b28423627d20d96f94c807ca259551907/ui/accessibility/platform/atk_util_auralinux.cc

Cc: thomasanderson@chromium.org
Status: Fixed (was: Unconfirmed)

Sign in to add a comment