Issue metadata
Sign in to add a comment
|
Blue background for learn more button is displayed for few seconds on opening a new incognito tab from tab switcher mode. |
||||||||||||||||||||||
Issue descriptionApp Version: 61.0.3163.0 canary iOS Version: 10.3.2 Device : iPad Steps to reproduce: 1. Launch chrome. 2. Tap on Menu > New incognito tab 3. Tap on tab switcher icon. 4. Tap on (+) to open a new incognito tab. Scenario 2 : 1.Launch chrome. 2. Swipe to bookmarks. 3. Tap on tab switcher icon. 4. Tap on (+) to open a new tab. Observed results: Blue button is displayed for few seconds. Expected results: Blue button flickering should not be seen. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: Not tested, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No in M59 Bug reproducible on the current beta channel build (App Version, iOS Version): No in M60 Link to video : https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpRnpyRVh6NFRmbVU/view?usp=sharing
,
Jul 24 2017
,
Sep 27 2017
,
Sep 27 2017
Pramod, could you please bisect good and bad revisions.
,
Sep 27 2017
Note that one possible fix is to add:
[learnMore setBackgroundColor:[UIColor clearColor]
forState:UIControlStateNormal];
right after the button's creation in incognito_view.mm
,
Sep 28 2017
Unable to repro the issue tested on iPad mini(9.3.5 & iOS 11) tested on the build 62.0.3202.39 beta. Blue background is not displayed
,
Sep 29 2017
,
Sep 29 2017
Now it's a black background. It's less visible because the page is dark gray, but it's still ugly.
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/565c8d96844cd257bdd7c2d899bdb6257bb904db commit 565c8d96844cd257bdd7c2d899bdb6257bb904db Author: Jean-François Geyelin <jif@chromium.org> Date: Tue Oct 24 09:48:47 2017 [iOS] Make the "Learn More" button have a transparent background. Bug: 747390 Change-Id: Iedb631ac872fcf211a196abf29bfb076ac1a5335 Reviewed-on: https://chromium-review.googlesource.com/692377 Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#511071} [modify] https://crrev.com/565c8d96844cd257bdd7c2d899bdb6257bb904db/ios/chrome/browser/ui/ntp/incognito_view.mm
,
Oct 24 2017
,
Oct 31 2017
Verified the issue on iPad Air on 10.3.3 tested on build version 64.0.3254.0 canary. Blue ot black background is not seen on Learn More button in incognito mode. looks good |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by fi...@chromium.org
, Jul 24 2017