New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747385 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 779617
issue 800988

Blocking:
issue 620551



Sign in to add a comment

Link to tryjob using buildbucket id

Project Member Reported by dgarr...@chromium.org, Jul 21 2017

Issue description

We can improve the build links produced when a tryjob is scheduled to have them go straight to the relevant build details pages by using the buildbucket ids.

From jinjingl:

You can then extract the builder name and build number from a buildbucket API response and construct the Luci build details link with that https://luci-milo.appspot.com/buildbot/chromeos/lakitu-st-paladin/295 

This would produce one link per build scheduled, instead of the current 'fuzzy' waterfall search. This would also fix assorted bugs with the current links, such as crbug.com/620551.
 
Blocking: 620551
Cc: uekawa@chromium.org
Owner: briannorris@chromium.org
Status: Started (was: Untriaged)
I played around with this and got something working today. I don't seem to see a "build number" included in the API response, but I do find a 'url' field (with one caveat below). This matches the documentation [1] I can find, which mentions the latter, but not the former.

It seems like the 'url' field only gets populated after a few seconds -- after the job is STARTED by buildbot. This matches the docs too ("Set by a build-system when the build is started").

Is it kosher to poll briefly until STARTED?

[1] https://chromium.googlesource.com/infra/infra/+/master/appengine/cr-buildbucket/doc/index.md
If all builders are busy, tryjobs can take a long time to start (worst case, hours).

Hopefully, we can generate a UI link doing nothing but the buildbucket id, which is available right away.

This URL is currently used by cros_tryjob for swarming tryjobs (still experimental and a bit broken), but should be usable for buildbot builds soonish.

BUILD_DETAILS_PATTERN = (
    'http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?'
    'buildbucketId=%(buildbucket_id)s'
)

Jinjing can give us a time estimate for getting support into production, but is out this week.
PS: I've been blocking finishing this on that support (which was partly blocked on something else I was working on, hopefully no longer).

Blockedon: 755334
Owner: ----
Status: Available (was: Started)
Thanks Don. I just noticed that code a few minutes ago. FWIW, it hits a NULL pointer exception on the backend service today :)

I'll give up on polling the buildbucket API then, since it sounds like it conceptually cannot work promptly. We'd need to point the user to some service that will lazily pick it up, such as goldeneye.
Owner: dgarr...@chromium.org
Assigning to me so it doesn't get lost.
Status: Started (was: Available)
Cc: dgarr...@chromium.org vapier@chromium.org hidehiko@chromium.org
 Issue 761706  has been merged into this issue.
Cc: manojgupta@chromium.org
 Issue 774733  has been merged into this issue.
Blockedon: -755334 779617
Labels: Legoland
Issue 779617 has been merged into this issue.
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/fde494b0614fb868b1ae1ce4a5106dc5f6fccce1

commit fde494b0614fb868b1ae1ce4a5106dc5f6fccce1
Author: Don Garrett <dgarrett@google.com>
Date: Tue Jan 09 06:42:11 2018

cros tryjob: Always display GE build details links.

Switch cros tryjob to always include the GE build links, but also
retain the waterfall links, for now.

BUG= chromium:747385 
TEST=run_tests && remote_try_unittest --network && manually launched tryjobs.

Change-Id: I64d3585a9b238c5cc7fc162c5115fa245062c510
Reviewed-on: https://chromium-review.googlesource.com/854687
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Jinjing Liang <jinjingl@google.com>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[modify] https://crrev.com/fde494b0614fb868b1ae1ce4a5106dc5f6fccce1/lib/remote_try.py
[modify] https://crrev.com/fde494b0614fb868b1ae1ce4a5106dc5f6fccce1/lib/remote_try_unittest.py

Blockedon: 800988
Status: Fixed (was: Started)
Status: Started (was: Fixed)
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b6979c1f9ec673519b09ffb74ca2261b54342fc4

commit b6979c1f9ec673519b09ffb74ca2261b54342fc4
Author: Don Garrett <dgarrett@google.com>
Date: Thu Mar 15 22:27:18 2018

cros tryjob: Remove buildbot URL generation.

Stop generating buildbot URLs at all. Previously, we added new
Legoland URLs. Depend on them 100%.

BUG= chromium:747385 
TEST=lib/remote_try.py --network

Change-Id: I4256ec56de273855609401fb5395f71a528ce09f
Reviewed-on: https://chromium-review.googlesource.com/858174
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/b6979c1f9ec673519b09ffb74ca2261b54342fc4/lib/remote_try.py
[modify] https://crrev.com/b6979c1f9ec673519b09ffb74ca2261b54342fc4/lib/remote_try_unittest.py

Status: Fixed (was: Started)
Project Member

Comment 19 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5

commit b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Mar 16 22:50:01 2018

Roll src/third_party/chromite/ 3b75c9d82..3ad8f333d (31 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3b75c9d82ebf..3ad8f333d567

$ git log 3b75c9d82..3ad8f333d --date=short --no-merges --format='%ad %ae %s'
2018-03-16 dgarrett Revert "Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq.""
2018-03-16 dgarrett Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq."
2018-03-14 ayatane autotest-pre-cq: Remove builder and stage [2/2]
2018-03-16 dgarrett Revert "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq."
2018-03-15 dgarrett chromeos_config: Move fuzzer builds into new bucket.
2018-03-16 dgarrett Revert "commands: RunBranchUtilTest -> RunLocalTryjob"
2018-03-13 dgarrett pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq.
2018-02-07 dgarrett commands: RunBranchUtilTest -> RunLocalTryjob
2018-03-14 dgarrett cbuildbot_run: Switch more build links to Legoland.
2018-03-13 dgarrett swarming_lib: Remove SWARMING_TASK_ID from cmds.
2018-03-08 dgarrett moblab_vm_unitest: Fix lint issues.
2018-03-14 ihf chromeos_config: add more arcnext experimental coverage.
2018-03-14 ayatane autotest-pre-cq: Remove this [1/2]
2018-03-14 norvez chromeos_config: remove dead code
2018-03-09 dgarrett summarize_build_stats: Add blank line at beginning.
2018-01-09 dgarrett cros tryjob: Remove buildbot URL generation.
2017-09-14 craigb image_test: Remove check that kernel is not ELF.
2018-03-15 ihf Revert "chromeos_config: temporarily mark eve-arcnext-paladin experimental"
2018-03-15 ihf Revert "chromeos_config: temporarily experimental eve-arcnext-mst-android-pfq"
2018-03-13 lhchavez chromeos_config: Add betty-arcnext builder config
2018-03-13 achuith cbuildbot: Add missing files to index.
2018-03-13 akeshet completion_stages: add a has_important_slave metric to master completion
2018-03-13 dgarrett precq-launcher: Start using Legoland build details page.
2018-03-08 dgarrett chromite-pre-cq: Disable CidbIntegrationTest.
2018-03-14 akeshet chromeos_config: temporarily experimental eve-arcnext-mst-android-pfq
2018-03-13 akeshet chromeos_config: temporarily mark eve-arcnext-paladin experimental
2018-03-12 haddowk [chromite] Make guado_moblab important again
2018-03-13 chrome-bot Update config settings by config-updater.
2018-03-12 gmeinke chromium-config: replace cros_config_host_py in chromite
2018-03-12 yunlian Enable ThinLTO on all AMD64 boards.
2018-03-12 achuith cbuildbot: Log timing of GenerateUploadJSON.

Created with:
  roll-dep src/third_party/chromite
BUG=821930, 822517 , 821615 ,None,821618,821227,None,821664,821930,None,815377,747385,461595,821664,821664,811989,819419,821618,820305,821664,821664,819017,813442,707803,811989


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib6aaddf338307e994865a092ecb322a432148692
Reviewed-on: https://chromium-review.googlesource.com/967273
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543855}
[modify] https://crrev.com/b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5/DEPS

Sign in to add a comment