Why isn't media/ part of the deps of //media/renderers.BUILD.gn? |
|||||||
Issue descriptionThis question stems from crbug.com/747229#c7 media/renderers/audio_renderer_impl.cc includes media/base/media_switches.h which in turn includes ppapi/features/features.h. ppapi/features/features.h is a generated file that is generated by the buildstep //ppapi/features:features, so if that buildstep is not run before we parse a file include ppapi/features/features.h, then it will look like ppapi/features/features.h is missing. media/renderers/renderers does not seem to have a dependency (i.e. gn deps) on either media/base, or ppapi/features, to me this seems wrong. Dale, is media/renderers supposed to depend on media/base (or is it actually depending on media/base, and I just missed the dependency) or am I missing something?
,
Jul 21 2017
,
Jul 27 2017
,
Jul 27 2017
,
Jul 27 2017
I think a.suchit@samsung.com is currently working on splitting of //media/BUILD.gn. May be I was assigned this issue by dalecurtis@chromium.org by mistake. Assigning this back to it's appropriate owner.
,
Jul 27 2017
,
Jul 27 2017
Yes, sorry for the incorrect assignment!
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b3329fdca90d0449fc8d4419bee11320e6c88c1 commit 5b3329fdca90d0449fc8d4419bee11320e6c88c1 Author: Suchit Agrawal <a.suchit@samsung.com> Date: Fri Jul 28 12:34:12 2017 //media/renderers should depend on //media/base. media/renderers/audio_renderer_impl.cc includes media/base/media_switches.h which in turn includes ppapi/features/features.h and it is generates in target //ppapi/features. //media/base is dependent on the //ppapi/features so //media/base added as dependency in //media/renderers. Bug= 747379 Signed-off-by: Suchit Agrawal <a.suchit@samsung.com> Change-Id: I9eb8e3f82d1e9425b5a324c129faa58d5c665ad8 Reviewed-on: https://chromium-review.googlesource.com/589467 Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#490369} [modify] https://crrev.com/5b3329fdca90d0449fc8d4419bee11320e6c88c1/media/base/BUILD.gn [modify] https://crrev.com/5b3329fdca90d0449fc8d4419bee11320e6c88c1/media/renderers/BUILD.gn
,
Jul 28 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dalecur...@chromium.org
, Jul 21 2017