NTPTilesTest.testTopSitesTileAfterRedirect look flaky |
|||||
Issue descriptionThis test randomly fails when I run ios_chrome_integration_egtests locally (Xcode 8.3.3, simulator, iPhone 7 Plus, iOS 10). When relaunching the test suite, the test generally pass, so I suspect some flakyness here.
,
Jul 21 2017
,
Jul 21 2017
baxley: should the test be marked as FLAKY?
,
Jul 21 2017
sdefresne@ - yes, probably. I wrote the test, so I should probably do the initial debugging. gambard@ - I won't complain if you take it back if you really want it though. :)
,
Jul 24 2017
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d199756965ab0a7181c89beca16ba5f745b4f69d commit d199756965ab0a7181c89beca16ba5f745b4f69d Author: Mike Baxley <baxley@chromium.org> Date: Fri Aug 04 21:39:13 2017 Call superclass tearDown in NTPTilesTest. This test overrides the per test tearDown, but had failed to call the superclass. Bug: 751224 , 747369 Change-Id: I895c9115439c06e8630013d4a958c3535b1a3047 Reviewed-on: https://chromium-review.googlesource.com/602682 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#492128} [modify] https://crrev.com/d199756965ab0a7181c89beca16ba5f745b4f69d/ios/chrome/browser/ntp_tiles/ntp_tiles_egtest.mm
,
Aug 5 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sdefresne@chromium.org
, Jul 21 2017Components: UI>Browser>NewTabPage