New issue
Advanced search Search tips

Issue 747368 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

jumbo chunk size depends on how many headers are listed

Project Member Reported by brat...@opera.com, Jul 21 2017

Issue description

Jumbo has a configurable limit of max chunk size (currently 200) but since the splitting is done before headers are filtered out, the chunks are sometimes much smaller than expected. 

For instance, third_party/WebKit/Source/core/html lists 610 files in sources which became 4 chunks of ~150 files, but after header filtering that was down to 4 chunks of ~75 files each. Since only 300 of the listed files were cc source files, it should have been 2 chunks of ~150 each.

It would be reasonable to change this and at the same time lower the default chunk size to 100 to get similar results as before.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1741b755a959e3732a6b6d422c488b7fb1067699

commit 1741b755a959e3732a6b6d422c488b7fb1067699
Author: Daniel Bratell <bratell@opera.com>
Date: Wed Jul 26 10:39:26 2017

Change jumbo chunk separation to ignore headers

Since jumbo chunks were divided before headers were filtered out, the
actual chunk sizes were not deterministic and much smaller than expected.

This patch filters headers first, and halves the chunk size to get the same
actual chunks.

Bug:  747368 
Change-Id: Ia537af07f7226a87d8de1309bf494914789609e4
Reviewed-on: https://chromium-review.googlesource.com/581289
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#489598}
[modify] https://crrev.com/1741b755a959e3732a6b6d422c488b7fb1067699/build/config/jumbo.gni

Comment 2 by brat...@opera.com, Sep 5 2017

Status: Fixed (was: Started)
This was fixed in July but I forgot to close the bug.

Sign in to add a comment