Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future? CL: https://chromium.googlesource.com/chromium/src/+/897b0f0e6b6054f5cf2419bf8891477a8eac1b20 Ref Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=731197 Thank you!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d92868cb835e3a37ff49db38e3e42afe110c411 commit 5d92868cb835e3a37ff49db38e3e42afe110c411 Author: Patrick Hulce <phulce@chromium.org> Date: Tue Oct 03 02:10:17 2017 DevTools: Add tests for audits2 panel * Introduces Audits2TestRunner and audits2 test folder. * Adds test coverage for default flow, limited category flow, and unauditable page message help text. * Fixes a bug where help text was not updated on URL change. BUG= 762911 , 747357 , 762906 , 762897 Change-Id: Ifa6475e344be28f8260a71e6a4a7b9eb9791b6c4 Reviewed-on: https://chromium-review.googlesource.com/661894 Commit-Queue: Patrick Hulce <phulce@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505924} [modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/SlowTests [add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt [add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run.js [add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run-expected.txt [add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run.js [add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt [add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run.js [modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js [add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/Audits2TestRunner.js [add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/module.json [modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js [modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js [modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/integration_test_runner.json [modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js [modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/services/module.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a commit ef8ea6202d4a01d4f05bff487a78e64e556b3e1a Author: Kentaro Hara <haraken@chromium.org> Date: Tue Oct 03 06:21:46 2017 Revert "DevTools: Add tests for audits2 panel" This reverts commit 5d92868cb835e3a37ff49db38e3e42afe110c411. Reason for revert: This broke virtual/mojo-loading/http/tests/devtools/audits2/audits2-successful-run.js on Win10. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/26198 Original change's description: > DevTools: Add tests for audits2 panel > > * Introduces Audits2TestRunner and audits2 test folder. > * Adds test coverage for default flow, limited category flow, and > unauditable page message help text. > * Fixes a bug where help text was not updated on URL change. > > BUG= 762911 , 747357 , 762906 , 762897 > > Change-Id: Ifa6475e344be28f8260a71e6a4a7b9eb9791b6c4 > Reviewed-on: https://chromium-review.googlesource.com/661894 > Commit-Queue: Patrick Hulce <phulce@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505924} TBR=dgozman@chromium.org,chenwilliam@chromium.org,phulce@chromium.org Change-Id: I28b0a59682a5db00980462f97b56a345354d8998 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 762911 , 747357 , 762906 , 762897 Reviewed-on: https://chromium-review.googlesource.com/696805 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#505967} [modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/LayoutTests/SlowTests [delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt [delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run.js [delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run-expected.txt [delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run.js [delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt [delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run.js [modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js [delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/Audits2TestRunner.js [delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/module.json [modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js [modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js [modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/integration_test_runner.json [modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js [modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/services/module.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b995386e813c30ff327f7d3be81a85a62272a30 commit 9b995386e813c30ff327f7d3be81a85a62272a30 Author: Patrick Hulce <phulce@chromium.org> Date: Thu Oct 05 01:23:39 2017 Reland "DevTools: Add tests for audits2 panel" Win10 tests will be skipped for now. This is a reland of 5d92868cb835e3a37ff49db38e3e42afe110c411 Original change's description: > DevTools: Add tests for audits2 panel > > * Introduces Audits2TestRunner and audits2 test folder. > * Adds test coverage for default flow, limited category flow, and > unauditable page message help text. > * Fixes a bug where help text was not updated on URL change. > > BUG= 762911 , 747357 , 762906 , 762897 > > Change-Id: Ifa6475e344be28f8260a71e6a4a7b9eb9791b6c4 > Reviewed-on: https://chromium-review.googlesource.com/661894 > Commit-Queue: Patrick Hulce <phulce@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505924} Bug: 762911 , 747357 , 762906 , 762897 Change-Id: Iaf210e383e86fbfe0e31b372d8b87c461e8beecb Reviewed-on: https://chromium-review.googlesource.com/701294 Reviewed-by: Will Chen <chenwilliam@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Patrick Hulce <phulce@chromium.org> Cr-Commit-Position: refs/heads/master@{#506608} [modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/SlowTests [modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt [add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run.js [add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run-expected.txt [add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run.js [add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt [add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run.js [modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js [add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/Audits2TestRunner.js [add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/module.json [modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js [modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js [modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/integration_test_runner.json [modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js [modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/services/module.json
Comment 1 by bugdroid1@chromium.org
, Oct 3 2017