New issue
Advanced search Search tips

Issue 747332 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

chrome://dino scaling

Project Member Reported by jif@chromium.org, Jul 21 2017

Issue description

The game looks blurry when in arcade mode.

I think we should be using "image-rendering: pixelated;" for the runner-canvas:
-On Hi-dpi screen it always looks better IMO.
-On Regular-dpi screen, maybe only adding this when the scale of the canvas is greater than some threshold.

Also, translateY should ideally be an integer. That would remove any blurriness in the ( admittedly unlikely case) that scale factor is itself an integer.

Finally, I noticed that the assets are not consistent (some have a white border, some haven't).
 
border vs no border.png
4.2 KB View Download
blurry vs pixelated.png
14.9 KB View Download
Thanks for the tip. Agree it looks better. I'll do some tests to find a good balance.


Project Member

Comment 2 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cf58c01d4e31a100ad3b62ff7ebeddc986e7e5f

commit 0cf58c01d4e31a100ad3b62ff7ebeddc986e7e5f
Author: Edward Jung <edwardjung@chromium.org>
Date: Mon Aug 07 13:36:56 2017

Offline dino bug fixes - correct ducking sprite border, improve scaling
+ Fixes the white border showing on the ducking sprite
+ Round the translateY positioning to prevent potential blurriness from the applied scaling.

Bug:  747332 
Change-Id: I0aa3ec20dbf0fd79cc70ee77891f3eafef2a5d3e
Reviewed-on: https://chromium-review.googlesource.com/596867
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Edward Jung <edwardjung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492310}
[modify] https://crrev.com/0cf58c01d4e31a100ad3b62ff7ebeddc986e7e5f/components/neterror/resources/default_100_percent/offline/100-offline-sprite.png
[modify] https://crrev.com/0cf58c01d4e31a100ad3b62ff7ebeddc986e7e5f/components/neterror/resources/default_200_percent/offline/200-offline-sprite.png
[modify] https://crrev.com/0cf58c01d4e31a100ad3b62ff7ebeddc986e7e5f/components/neterror/resources/offline.js

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c2fabe6f8f6209d3cd6a408bd650df45abc9321

commit 3c2fabe6f8f6209d3cd6a408bd650df45abc9321
Author: Peter Boström <pbos@chromium.org>
Date: Mon Aug 07 20:54:19 2017

Make chrome://dino/ pixelated when upscaled.

Currently the chrome://dino/ arcade mode upscales the game canvas using
bilinear filtering (or some other "fancy" non-nearest-neighbour filter).
This is fine and normally preferred for images, but our pixelated friend
is way too old-school for that.

As such we apply the CSS3 style "image-rendering: 'pixelated';" to match
the era of the dinosaur game. This gives our retro friend a look more
reminiscent of its past.

See: https://drafts.csswg.org/css-images-3/#valdef-image-rendering-pixelated

BUG= chromium:747332 
R=edwardjung@chromium.org, mmenke@chromium.org

Change-Id: I365642df3b420fac4e4b85aba6499b7358cdfbcd
Reviewed-on: https://chromium-review.googlesource.com/592310
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Edward Jung <edwardjung@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492401}
[modify] https://crrev.com/3c2fabe6f8f6209d3cd6a408bd650df45abc9321/components/neterror/resources/neterror.css

Comment 4 by pbos@chromium.org, Aug 7 2017

Cc: pbos@chromium.org

Comment 5 by jif@chromium.org, Aug 8 2017

Thank you!
Status: Fixed (was: Assigned)

Sign in to add a comment