New issue
Advanced search Search tips

Issue 747267 link

Starred by 1 user
Status: Archived
Owner:
sky@chromium.org
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Add Mash support for listening to DeviceDataManager / InputDeviceClient in LoginDisplayHostImpl

Project Member Reported by felixe@chromium.org, Jul 21 2017 
https://chromium-review.googlesource.com/c/575138 added support for listening to changes in touch devices to the non-Mash case. For symmetry and to avoid depending on implementation details in OobeUi/OobeDisplayChooser we should add a listener to InputDeviceClient in the Mash case.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9b7fc1ea04c26a52591a85f893c646dee46c2b1

commit b9b7fc1ea04c26a52591a85f893c646dee46c2b1
Author: Scott Violet <sky@chromium.org>
Date: Thu Aug 10 16:37:26 2017

chromeos: convert usage of DeviceDataManager to InputDeviceManager

This code was using DeviceDataManager directly, which is only
available in the UI service. Instead it should be using
InputDeviceManager, which works outside of the UI service.

I'm working on adding DEPS to ensure this doesn't happen again.

BUG= 747267 
TEST=none

Change-Id: I27748fb2caab46833712f95160e7b0fd44939f9d
Reviewed-on: https://chromium-review.googlesource.com/609124
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493423}
[modify] https://crrev.com/b9b7fc1ea04c26a52591a85f893c646dee46c2b1/chrome/browser/chromeos/login/ui/login_display_host_impl.cc

Comment 2 by sky@chromium.org, Aug 10 2017

Owner: sky@chromium.org
Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment