Code cleanup for iOS bookmark: check if the scrolling offset's 2 / 3.0 conversion is needed. |
|||
Issue description
In ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm,
when storing/restoring the scrolling position of the bookmark panel.
there is a conversion (for wide LangscapeMode):
position = position * 2 / 3.0 (when restoring)
or * 3 / 2.0 (when storing)
inside the function contentPositionInPortraitOrientation and applyContentPosition.
I was wondering if that conversion is still needed? or just a useless code.
,
Oct 12 2017
,
Sep 27
We now store the number of the top most visible cell instead of the offset, this code no longer exists. |
|||
►
Sign in to add a comment |
|||
Comment 1 by olivierrobin@chromium.org
, Jul 21 2017Status: Assigned (was: Untriaged)