New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747245 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: YouTube page turns blank upon auditing.

Reported by aiman.an...@etouch.net, Jul 21 2017

Issue description

Chrome Version: 61.0.3163.0 (Official Build) f259bab28b35d242e10186cd63af7ed404fae0d-frefs/heads/master@{#488528}(64-bit)

OS: Win(7,8,10), Linux(14.04 LTS), Mac(10.12.3, 10.11.6).

Steps to reproduce:
1) Launch Chrome, go to https://www.youtube.com/?gl=IN open Dev tool and run Audit.
2) Observe.

Actual Result: YouTube page turns blank upon auditing.
Expected Result: Page should not turn blank.

This is Regression issue broken in M-61 and will soon update bisect info.

Manual Bisect Info:
Good Build: 61.0.3163.0
Bad Build: 61..0.3162.0
 
Actual Result.mov
6.9 MB Download
Expected Result.mov
5.8 MB Download
Correction:
Good Build: 61.0.3162.0
Bad Build: 61.0.3163.0
Labels: hasbisect-per-revision
Owner: jrumm...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue using #61.0.3163.0 on Mac 10.12.5, Win 10, Linux Ubuntu 14.04.

Per revision bisect info:
------------------------

You are probably looking for a change made after 488073 (known good), but no later than 488074 (first known bad).

CHANGELOG URL
=============

https://chromium.googlesource.com/chromium/src/+log/46d636d25e054da0b0d8270d525c84f39146ce30..eff649e5432b165fa030a5208ad87841178b7e63

@jrummell: Please take a look and reassign to the right owner if it is not related to your change.

Reviewed-on: https://chromium-review.googlesource.com/571339

Thanks..!!

Labels: ReleaseBlock-Beta
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
Owner: ----
Status: Untriaged (was: Assigned)
Does not repro for me. I ran Version 61.0.3163.0 (Official Build) canary (64-bit) on Windows, and at the end of the audit it simply presents a dialog for me to create a channel (screenshot attached). Clicking on cancel gets back to the screen as expected in ExpectedResult.mov.

My CL affected code used when playing encrypted media. I doubt it is the reason for this problem, as it's unlikely that the YouTube home page contains encrypted media. Plus if it was really the problem, I would expect to see bugs noting that Google Play/Netflix/... fail.

Not sure where the problem may be. At the end of the audit the page loaded (for me) is https://www.youtube.com/create_channel?upsell=channel&next=%2Ffeed%3Flayout%3Dmobile%26tsp%3D1%26utcoffset%3D-420%26app%3Ddesktop, which would explain the dialog. In ExpectedResult.mov it goes to https://m.youtube.com. In ActualResult.mov it goes to https://www.youtube.com/feed?layout=mobile&tsp=1&utcoffset=330&app=desktop. So I would assume it is a problem with audit not returning to the original page when done auditing.

(I tried https://www.youtube.com/feed?layout=mobile&tsp=1&utcoffset=330&app=desktop directly, and it redirects me to the create_channel page. So I would assume that maybe you already have a YouTube channel created. But either way, it appears the blank screen is due to the page loaded at the end of the audit, and not a bug in the way Chrome displays the page.)

sandeepkumars@, can you try loading https://www.youtube.com/feed?layout=mobile&tsp=1&utcoffset=330&app=desktop on whatever machine you ran these tests? If it comes back blank, then maybe there is also a problem with YouTube.

For fun, I tried this on the current public Chrome (Version 60.0.3112.72 (Official Build) beta (64-bit)). At the end of Audit it ends up at https://pubads.g.doubleclick.net/gampad/ads?ad_rule=0&d_imp=1&gdfp_req=1&iu=%2F6762%2Fmkt.ythome_1x1&pucrd=CgYIABAAGAA&scp=dc_yt%3D1%26kga%3D-1%26kgg%3D-1%26klg%3Den%26kmyd%3Dad_creative_3%26ssl%3D1%26ytexp%3D9405976%252C9410705%252C9419452%252C9422596%252C9431012%252C9434289%252C9451825%252C9457023%252C9460350%252C9462380%252C9465813%252C9466591%252C9466981%252C9469328%252C9472778%252C9474595%252C9476196%252C9478524%252C9479646%252C9479708%252C9479862%252C9481292%252C9482851%252C9482983%252C9483496%252C9483750%252C9484337&sz=1x1&correlator=4605856309036900, with a totally different score (and a blank page).

I don't know who works on Dev tools. Somebody from that team should investigate why Audit ends up at a different page at the end of the test. Marking this bug as untriaged so that somebody from DevTools can pick it up.
YouTubeAudit.jpg
232 KB View Download

Comment 5 by ajha@chromium.org, Jul 24 2017

Somehow on the latest canary(62.0.3165.0), I am unable to run the audit on Youtube page. Attached is the screenshot of the same.

aiman.ansari@: Could you check this again and confirm if this issue is still relevant.


747245_Audit_Run_Disabled.png
738 KB View Download

Comment 6 by caseq@chromium.org, Jul 24 2017

Cc: phulce@chromium.org paulir...@chromium.org

Comment 7 by caseq@chromium.org, Jul 24 2017

Status: Unconfirmed (was: Untriaged)
Owner: paulir...@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 9 by gov...@chromium.org, Jul 24 2017

A friendly reminder that M61 Beta promotion is coming soon! Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix and request a merge to M61 branch 3163 latest by 4:00 PM PT, Thursday (07/27). Thank you.
Just to update, rechecked this issue on Canary build 62.0.3166.0 on MAC and Ubuntu 14.04 and still able to reproduce it. 

@paulirish: request you to please take a look into it. Issue is tagged with a Beta blocker and M61 is set to be pushed to beta soon.

Thanks.!
There's two issues here. One ours and one youtube's.

Youtube's bug: navigating to this URL (https://www.youtube.com/feed?layout=mobile&tsp=1&utcoffset=-420&app=desktop) delivers a white page when you're logged out of youtube.

Our bug: a race condition between navigating to the original page and turning off emulation. This is an easy fix. I'll get that in.
Thank you  paulirish@. Could you pls land fix for our bug ASAP to trunk and request a merge to M61 if Canary result looks good? 
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/592464/
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52c95c0c41c7ad2c08bae40454d5ec7556c856ec

commit 52c95c0c41c7ad2c08bae40454d5ec7556c856ec
Author: Paul Irish <paulirish@chromium.org>
Date: Sat Jul 29 04:42:21 2017

DevTools: [Audits] Fix race during emulation state reset

Updated emulation state is applied in stopAndReattach, 
but that was racing against the state being reset within
hideDialog. 

Bug:  747245 
Change-Id: I1c1698525691f37d4c988349cd7bc84a23a3e7f6
Reviewed-on: https://chromium-review.googlesource.com/592464
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490624}
[modify] https://crrev.com/52c95c0c41c7ad2c08bae40454d5ec7556c856ec/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

Cc: gov...@chromium.org
Labels: TE-Verified-62.0.3172.0 TE-Verified-M62
Rechecked this issue on Chrome Canary Version 62.0.3172.0 on Windows  10, Mac 10.12.6, Ubuntu 14.04. Fix is working as intended. No Blank page is displayed after performing an Audit operation. Screen shot attached and adding TE-verified labels.

Thanks.!
Audit-Devtools.png
3.2 MB View Download
Labels: Merge-Request-61
We've also discovered an issue affecting youtube.com where Audits will not run, reporting that "multiple tabs are open", however only a single tab is open. I will prepare a CL to address this.
I split the issue described in c17 out to a separate ticket: https://bugs.chromium.org/p/chromium/issues/detail?id=750767
Labels: -Merge-Request-61 Merge-Approved-61
Thank you  paulirish@. Approving merge for CL listed at #14 based on comment #15. Please merge ASAP.
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 31 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d00753002fc2a632f9b8b54ac2fdeade3b3613d1

commit d00753002fc2a632f9b8b54ac2fdeade3b3613d1
Author: Paul Irish <paulirish@chromium.org>
Date: Mon Jul 31 19:01:42 2017

DevTools: [Audits] Fix race during emulation state reset

Updated emulation state is applied in stopAndReattach,
but that was racing against the state being reset within
hideDialog.

TBR=paulirish@chromium.org

(cherry picked from commit 52c95c0c41c7ad2c08bae40454d5ec7556c856ec)

Bug:  747245 
Change-Id: I1c1698525691f37d4c988349cd7bc84a23a3e7f6
Reviewed-on: https://chromium-review.googlesource.com/592464
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490624}
Reviewed-on: https://chromium-review.googlesource.com/594654
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#173}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/d00753002fc2a632f9b8b54ac2fdeade3b3613d1/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

Note: Unable to run Audit for YouTube on latest Canary #62.0.3173.0 for Win(7,8,10), Mac(!0.11.6, 10.12.3) and Linux(14.04 LTS).
Youtube_Audit.png
710 KB View Download
@aiman, that issue was filed as  issue 750767  and a fix has now landed. If r491063 makes tomorrow's canary then it'll be available to test then.

I will also be requesting a merge on 750767 when it's baked.
Note:
Retested the above issue on latest Canary 62.0.3179.0 for Win(7,8,10), Linux(14.04 LTS), Mac(10.12.3, 10.11.6).
Issue is not reproducible and is working as intended.
Labels: TE-Verified-M61 TE-Verified-61.0.3163.39
Note:
Retested the above issue on 61.0.3163.39 for Win(7,8,10), Linux(14.04 LTS), Mac(10.12.3, 10.11.6).
Issue is not reproducible and is working as intended.
Can this be marked as fixed now?
Status: Fixed (was: Started)
yes thanks

Sign in to add a comment