New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747234 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Blank drop down list is seen in 'Audit' section of devtools.

Reported by rp...@etouch.net, Jul 21 2017

Issue description

Version: 61.0.3163.0 ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528
OS: Windows (7,8,8.1,10),Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP and open devtools
2. Now go to 'Audits' section and observe

Actual: Blank drop down list is seen in 'Audit' section
Expected: Blank drop down list should not be seen in 'Audit' section

This is regression issue, broken in ‘M 61’ and will soon update other info :
Good build:61.0.3162.0
Bad build: 61.0.3163.0
 
Actual_video.mp4
376 KB View Download
Expected_video.mp4
429 KB View Download

Comment 1 by rp...@etouch.net, Jul 21 2017

Labels: OS-Mac
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: paulir...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:61.0.3162.0(Revision:488073).
Bad build:61.0.3163.0(Revision:488528).

You are probably looking for a change made after 488135 (known good), but no later than 488136 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/1c955f0530f6fe3f0f5bfdbe071d0c680a615b99..830b21927c2ad4ad9982d4b261d4eb3d4ab68451

From the CL above, assigning the issue to the concern owner

@paulirish : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Reviewed-on: https://chromium-review.googlesource.com/576359
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.5 and Able to reproduce in latest Canary #61.0.3163.0
Adding Release Block-Stable for this issue.Please remove if not the case.

Known issue, but sure I'll fix this. :)

Thanks
 paulirish@ would be nice to have the fix sooner(before Beta launch) if possible for better coverage during M61 Beta.

Comment 5 by gov...@chromium.org, Jul 26 2017

URGENT - PTAL.
Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the M61 branch #3163 ASAP to have enough baking time in Beta before Stable promotion. Thank you!

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label.

Still able to reproduce the issue on Ubuntu 14.04 using latest chrome version 62.0.3179.0

paulirish@ Could you please look into this issue as it has been marked as a stable blocker.

Thanks!
[Bulk Edit]
URGENT - PTAL.
Your bug is labelled as M61 Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP.

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label.

Thank you.

Labels: -ReleaseBlock-Stable
We're comfortable shipping with this. I'd like to fix it but it doesn't block stable.
Irish, mind if I take a look at fixing this one today? Seems simple enough to knock out pretty quickly. It just needs a conditional render.
So, conditional rendering on this is difficult since the select box basically needs to exist as things are currently done. Since the main problem is that it is *empty*, perhaps we can tackle this a different way.

Let's have a default option that says, "Perform an audit" that will be removed when the first one is inserted. That way it isn't entirely empty and the node is in place for use once an audit item is added.

Sound good?
And here is a patch file of what I'm thinking will work. Just let me know if this is an acceptable resolution and I'll update my Chromium pull and submit a request for it.
default-option.diff
1.5 KB Download
Status: Fixed (was: Assigned)
Audits panel UI was redone in https://chromium-review.googlesource.com/c/chromium/src/+/1058708

This bug has now been fixed.

Sign in to add a comment