Regression : Vertical scroll bar is missing in 'Audit' section of devtools
Reported by
rp...@etouch.net,
Jul 21 2017
|
|||||||||
Issue descriptionVersion: 61.0.3163.0 ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528 OS: Windows (7,8,8.1,10),Linux (14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, navigate to NTP and open devtools 2. Now go to 'Audits' section and run audit,observe Actual: Vertical scroll bar is missing in 'Audit' section Expected: Vertical scroll bar should be seen in 'Audit' section This is regression issue, broken in ‘M 61’ and will soon update other info : Good build:61.0.3162.0 Bad build: 61.0.3163.0
,
Jul 21 2017
Using the per-revision bisect providing the bisect results, Good build:61.0.3162.0(Revision:488073). Bad build:61.0.3163.0(Revision:488528). You are probably looking for a change made after 488135 (known good), but no later than 488136 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/1c955f0530f6fe3f0f5bfdbe071d0c680a615b99..830b21927c2ad4ad9982d4b261d4eb3d4ab68451 From the CL above, assigning the issue to the concern owner @paulirish : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url: https://chromium-review.googlesource.com/576359 Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.5 and Able to reproduce in latest Canary #61.0.3163.0 Adding Release Block-Beta for this issue.Please remove if not the case.
,
Jul 21 2017
Fix coming in https://chromium-review.googlesource.com/c/580500/ Cheers
,
Jul 21 2017
,
Jul 24 2017
A friendly reminder that M61 Beta promotion is coming soon! Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix and request a merge to M61 branch 3163 latest by 4:00 PM PT, Thursday (07/27). Thank you.
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2afd2acd7372a385ce3fa81b0dcc49064c93abe commit f2afd2acd7372a385ce3fa81b0dcc49064c93abe Author: Paul Irish <paulirish@chromium.org> Date: Mon Jul 24 22:22:02 2017 DevTools: [Audits] Roll Lighthouse 2.3.0 w/ dense report Also fixing: solid white background, scrolling restored, removing unneeded call to `Input.setIgnoreInputEvents` and 'Run audit' button has autofocus. Rolled LH commit: 924e1f11bd6b31f3a105185a8d667143770f3c65 Bug: 663085, 723966 , 747231 Change-Id: Id8f9c34a80fc0d251c07b9633fcd83a81cadc95c Reviewed-on: https://chromium-review.googlesource.com/580500 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#489099} [modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js [modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/audits2Panel.css [modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/category-renderer.js [modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/crc-details-renderer.js [modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js [modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/dom.js [modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js [modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/util.js [modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/report-styles.css [modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/templates.html [modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js
,
Jul 25 2017
,
Jul 25 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
,
Jul 25 2017
,
Jul 26 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 26 2017
Pls merge you change to M61 branch 3163 by 5:00 PM today, Wednesday if possible so we can take it in for next week M61 last dev release. Thank you.
,
Jul 27 2017
Gentle ping on the merge. Please merge to M61 branch 3163 ASAP. Thank you.
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04561f437bff516fee6c50db2f6c571a29efa9cb commit 04561f437bff516fee6c50db2f6c571a29efa9cb Author: Paul Irish <paulirish@chromium.org> Date: Fri Jul 28 21:23:29 2017 DevTools: [Audits] Roll Lighthouse 2.3.0 w/ dense report Also fixing: solid white background, scrolling restored, removing unneeded call to `Input.setIgnoreInputEvents` and 'Run audit' button has autofocus. Rolled LH commit: 924e1f11bd6b31f3a105185a8d667143770f3c65 TBR=paulirish@chromium.org (cherry picked from commit f2afd2acd7372a385ce3fa81b0dcc49064c93abe) Bug: 663085, 723966 , 747231 Change-Id: Id8f9c34a80fc0d251c07b9633fcd83a81cadc95c Reviewed-on: https://chromium-review.googlesource.com/580500 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489099} Reviewed-on: https://chromium-review.googlesource.com/592402 Reviewed-by: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#114} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js [modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/audits2Panel.css [modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/category-renderer.js [modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/crc-details-renderer.js [modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js [modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/dom.js [modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js [modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/util.js [modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/report-styles.css [modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/templates.html [modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js
,
Aug 1 2017
Rechecked this issue on Windows 8 and Mac 10.11.6 & Linux(14.04 LTS) OS using chrome version 61.0.3163.25 and fix is working as expected. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by rp...@etouch.net
, Jul 21 2017174 KB
174 KB View Download