Issue metadata
Sign in to add a comment
|
Files app: File list is not focused when quick view is closed. |
||||||||||||||||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Open Files app and select a file. (2) Press SPACE to open quick view. (3) Press SPACE to close quick view. What is the expected result? The file list is focused again. What happens instead? The file list is not focused. I think this is because we lost 'iron-overlay-closed' event when migrated to <dialog>. https://codesearch.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/quick_view_controller.js?l=147 If there is an alternative in <dialog>, we need to use it.
,
Jul 21 2017
I meant <dialog> fires a 'close' event (cr-dialog also fires it, but it is not relevant in this case).
,
Jul 24 2017
,
Jul 24 2017
Thanks dpapad@! Just renaming 'iron-overlay-closed' to 'close' seems to work for our case.
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e07ad2c4c76baf7ea1f4489a0dc067d7962a316e commit e07ad2c4c76baf7ea1f4489a0dc067d7962a316e Author: Klemen Kozjek <klemenko@google.com> Date: Mon Jul 24 06:06:23 2017 Files app: Return focus to the files list when quick view closes As a result, files that were selected before quick view opened will regain focus after the quick view dialog closes. Bug: 747230 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ida4bcd1a9b1578a78da5c451522eaf43c675b0d2 Reviewed-on: https://chromium-review.googlesource.com/582251 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Klemen Kozjek <klemenko@google.com> Cr-Commit-Position: refs/heads/master@{#488921} [modify] https://crrev.com/e07ad2c4c76baf7ea1f4489a0dc067d7962a316e/ui/file_manager/file_manager/foreground/elements/files_quick_view.js [modify] https://crrev.com/e07ad2c4c76baf7ea1f4489a0dc067d7962a316e/ui/file_manager/file_manager/foreground/js/quick_view_controller.js
,
Jul 24 2017
,
Jul 25 2017
,
Jul 26 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 26 2017
,
Jul 28 2017
This problem is still prevalent on M61 Dev build (9765.9.0, 61.0.3163.16), but fixed on M62 dev build (9784.0.0, 62.0.3166.0).
,
Jul 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2488bacd4b2c0ff7a20b468439896d8686d05d95 commit 2488bacd4b2c0ff7a20b468439896d8686d05d95 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Mon Jul 31 05:59:48 2017 Files app: Return focus to the files list when quick view closes As a result, files that were selected before quick view opened will regain focus after the quick view dialog closes. TBR=klemenko@google.com (cherry picked from commit e07ad2c4c76baf7ea1f4489a0dc067d7962a316e) Bug: 747230 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ida4bcd1a9b1578a78da5c451522eaf43c675b0d2 Reviewed-on: https://chromium-review.googlesource.com/582251 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Klemen Kozjek <klemenko@google.com> Cr-Original-Commit-Position: refs/heads/master@{#488921} Reviewed-on: https://chromium-review.googlesource.com/593380 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#139} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/2488bacd4b2c0ff7a20b468439896d8686d05d95/ui/file_manager/file_manager/foreground/elements/files_quick_view.js [modify] https://crrev.com/2488bacd4b2c0ff7a20b468439896d8686d05d95/ui/file_manager/file_manager/foreground/js/quick_view_controller.js
,
Aug 3 2017
Verified on M61 (Chrome OS 9765.16.0, 61.0.3163.30 dev build). |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dpa...@chromium.org
, Jul 21 2017