Translate auto-never (Android) should be configurable by Finch |
|||||||
Issue descriptionTranslate auto-never (Android) should be configurable by Finch
,
Jul 21 2017
Assigned to Marti who implemented it.
,
Jul 24 2017
I guess we need to make the following 4 parameters configurable: - Auto-Always Threshold (default: 5) - Auto-Never Threshold (default: 7) - Max number of Auto-Always (default: 2) - Max number of Auto-Never (default: 2) Thoughts?
,
Jul 24 2017
also. please advise if we need to make the default value of Auto-Never threshold bigger. thx!
,
Jul 24 2017
Those 4 params LGTM. With regard to upping the auto-never number, I really think we should, I'd suggest to 10. Consider these beta metric: 31% of users are clicking "Cancel" on the auto-never snackbar. That's compared to only 5.5% of users who are doing that for auto-always.
,
Jul 25 2017
cool. Thank Yana!
,
Jul 26 2017
Fixed (https://chromium-review.googlesource.com/c/583829/) We could configure those parameters in Finch experiment now.
,
Jul 28 2017
Requesting a merge to M61 for this cl: https://chromium-review.googlesource.com/c/583829/ (CL is not shown here, as a wrong bug number was accidentally used on the CL)
,
Jul 29 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 1 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cae302cfa0c8c5e121283523a1b8a8450ca7488 commit 2cae302cfa0c8c5e121283523a1b8a8450ca7488 Author: Marti Wong <martiw@google.com> Date: Tue Aug 01 20:48:36 2017 Make Translate (Android) auto-never/always configurable by Finch. Make the following 4 parameters configurable by Finch: - Auto-Always Threshold (default: 5) - Auto-Never Threshold (default: changed from 7 to 10) - Max number of Auto-Always (default: 2) - Max number of Auto-Never (default: 2) TBR=martiw@chromium.org (cherry picked from commit 7befbf9f0c2469bacb9a317478207fa5eaf2708c) Bug: 747215 Change-Id: I80a26c873ee72d7cb4f6f376766952ca12b641e7 Reviewed-on: https://chromium-review.googlesource.com/583829 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Marti Wong <martiw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489519} Reviewed-on: https://chromium-review.googlesource.com/590967 Cr-Commit-Position: refs/branch-heads/3163@{#218} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/2cae302cfa0c8c5e121283523a1b8a8450ca7488/chrome/browser/ui/android/infobars/translate_compact_infobar.cc [modify] https://crrev.com/2cae302cfa0c8c5e121283523a1b8a8450ca7488/chrome/browser/ui/android/infobars/translate_compact_infobar.h |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by goog...@chromium.org
, Jul 21 2017