New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747215 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Translate auto-never (Android) should be configurable by Finch

Project Member Reported by napper@chromium.org, Jul 21 2017

Issue description

Translate auto-never (Android) should be configurable by Finch
 
Thanks for tracking this.
Cc: goog...@chromium.org
Owner: martiw@chromium.org
Assigned to Marti who implemented it.

Comment 3 by martiw@chromium.org, Jul 24 2017

Cc: ramyasharma@chromium.org napper@chromium.org yyushkina@chromium.org
I guess we need to make the following 4 parameters configurable:
- Auto-Always Threshold (default: 5)
- Auto-Never Threshold (default: 7)
- Max number of Auto-Always (default: 2)
- Max number of Auto-Never (default: 2)

Thoughts?

Comment 4 by martiw@chromium.org, Jul 24 2017

also. please advise if we need to make the default value of Auto-Never threshold bigger.  thx!
Those 4 params LGTM. With regard to upping the auto-never number, I really think we should, I'd suggest to 10.  Consider these beta metric: 31% of users are clicking "Cancel" on the auto-never snackbar. That's compared to only 5.5% of users who are doing that for auto-always. 

Comment 6 by martiw@chromium.org, Jul 25 2017

cool. Thank Yana!

Comment 7 by martiw@chromium.org, Jul 26 2017

Status: Fixed (was: Assigned)
Fixed (https://chromium-review.googlesource.com/c/583829/)
We could configure those parameters in Finch experiment now.

Comment 8 by martiw@chromium.org, Jul 28 2017

Labels: Merge-Request-61
Requesting a merge to M61 for this cl: https://chromium-review.googlesource.com/c/583829/
(CL is not shown here, as a wrong bug number was accidentally used on the CL)
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 29 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by sheriffbot@chromium.org, Aug 1 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 1 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cae302cfa0c8c5e121283523a1b8a8450ca7488

commit 2cae302cfa0c8c5e121283523a1b8a8450ca7488
Author: Marti Wong <martiw@google.com>
Date: Tue Aug 01 20:48:36 2017

Make Translate (Android) auto-never/always configurable by Finch.

Make the following 4 parameters configurable by Finch:
- Auto-Always Threshold (default: 5)
- Auto-Never Threshold (default: changed from 7 to 10)
- Max number of Auto-Always (default: 2)
- Max number of Auto-Never (default: 2)

TBR=martiw@chromium.org

(cherry picked from commit 7befbf9f0c2469bacb9a317478207fa5eaf2708c)

Bug:  747215 
Change-Id: I80a26c873ee72d7cb4f6f376766952ca12b641e7
Reviewed-on: https://chromium-review.googlesource.com/583829
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Marti Wong <martiw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489519}
Reviewed-on: https://chromium-review.googlesource.com/590967
Cr-Commit-Position: refs/branch-heads/3163@{#218}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/2cae302cfa0c8c5e121283523a1b8a8450ca7488/chrome/browser/ui/android/infobars/translate_compact_infobar.cc
[modify] https://crrev.com/2cae302cfa0c8c5e121283523a1b8a8450ca7488/chrome/browser/ui/android/infobars/translate_compact_infobar.h

Sign in to add a comment