Issue metadata
Sign in to add a comment
|
Ask Google for suggestions button text is blurry
Reported by
sits...@gmail.com,
Jul 21 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36 Steps to reproduce the problem: 1. Go to chrome://settings/?search=spelling+errors and ensure Use a web service to help resolve is toggled to off. 2. Go to a page with a text box and type Opyt . 3. Press the right mouse button over Opyt and select "Ask Google for Suggestions". 4. Look at the buttons in the pop up that appears. What is the expected behavior? Button text to be as sharp as the usual button text (i.e. as sharp as the text in the "Choose file" button). What went wrong? Pop up's button text (such as "No Thanks") looks blurrier than the text in other widgets. Did this work before? N/A Chrome version: 59.0.3071.115 Channel: stable OS Version: OS X 10.12.6 Flash Version:
,
Jul 21 2017
,
Jul 21 2017
This dialog is already wired up behind chrome://flags/#secondary-ui-md The Cocoa version is an awful special snowflake dialog. I think we should seriously consider scrapping it in the m62 timeframe (independent of Harmony). The web-payments use case is putting eyes on MacViews at a framework level in default builds, so I'm not too worried about subtle regressions. And geez, just about anything would be better than the Cocoa dialog we have...
,
Jul 21 2017
shrike: what do you think of swapping this over to the Views version instead of the Cocoa one? The other option is to fix up the Cocoa once, which I could also do.
,
Aug 5 2017
I'm OK with the Views version (I guess) as the close button gets removed and rpop@ is OK with switching to it.
,
Aug 5 2017
The proposed change looks far nicer and is in keeping with other "popup dialogs" such as the basic auth "Authentication Required" dialog.
,
Jan 23 2018
Guessing this is fixed with Harmony?
,
Jan 24 2018
The blurriness is fixed by Harmony, but the swap over to the Views one did not happen. It should require only a change in /chrome/browser/ui/cocoa/confirm_bubble_views_mac.mm to always use this dialog. I'll get to this this week.
,
Jan 26 2018
The NextAction date has arrived: 2018-01-26
,
Jan 26 2018
This change will cause us to only use the Views confirm bubble: <https://chromium-review.googlesource.com/c/chromium/src/+/889139>
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f452a4d3d55d918af1962f26a7c6678b21a486f commit 6f452a4d3d55d918af1962f26a7c6678b21a486f Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Feb 01 19:20:07 2018 mac: always use Views confirm bubble The confirm bubble is used only for the "Ask Google for Spelling Suggestions?" prompt. The Cocoa bubble has some visual defects, but the Views one looks quite a bit better. Bug: 747203 Change-Id: I7876819a1b4dd96d32f4491ac67187be5c941c3c Reviewed-on: https://chromium-review.googlesource.com/889139 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#533769} [modify] https://crrev.com/6f452a4d3d55d918af1962f26a7c6678b21a486f/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/91c3dd76adc19349c7296521ef67014b27b51262/chrome/browser/ui/cocoa/confirm_bubble_cocoa.h [delete] https://crrev.com/91c3dd76adc19349c7296521ef67014b27b51262/chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm [delete] https://crrev.com/91c3dd76adc19349c7296521ef67014b27b51262/chrome/browser/ui/cocoa/confirm_bubble_controller.h [delete] https://crrev.com/91c3dd76adc19349c7296521ef67014b27b51262/chrome/browser/ui/cocoa/confirm_bubble_controller.mm [delete] https://crrev.com/91c3dd76adc19349c7296521ef67014b27b51262/chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm [delete] https://crrev.com/91c3dd76adc19349c7296521ef67014b27b51262/chrome/browser/ui/cocoa/confirm_bubble_views_mac.mm [modify] https://crrev.com/6f452a4d3d55d918af1962f26a7c6678b21a486f/chrome/browser/ui/views/confirm_bubble_views.cc [modify] https://crrev.com/6f452a4d3d55d918af1962f26a7c6678b21a486f/chrome/test/BUILD.gn
,
Feb 1 2018
Fixed! Begone old cocoa bubble :) |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nyerramilli@chromium.org
, Jul 21 2017