Options for share menu is duplicated |
|||||||||
Issue descriptionChrome version: 61.0.3162 (dev) platform: 9763.0.0 (dev) caroline device 1. Downloaded few images. 2. Installed android apps- photos, keep, hangouts, drive 3. On selection of all 3 images, and on click of share menu, duplicated list of options appear. Please refer the attachment
,
Jul 21 2017
fukino@ - Could you take a look? Maria observed this yesterday, but I was not able to reproduce. Might be a specific version where this is occurring. My version = 61.0.3159.8 | 9756.2.0
,
Jul 24 2017
,
Jul 24 2017
,
Jul 24 2017
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1da3e650170117d8d5173fa0ed2f32d40424c3a6 commit 1da3e650170117d8d5173fa0ed2f32d40424c3a6 Author: Naoki Fukino <fukino@chromium.org> Date: Tue Jul 25 07:37:48 2017 Files app: Fix condition to remove existing share-related items. Share items except for <cr-menu-item command="#share"> should be cleared when we re-create the share options menu, but the condition was wrong and existing items were not removed correctly. Bug: 747200 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8e61f9ec65176cd4f21bdcf8b9102db0695b1063 Reviewed-on: https://chromium-review.googlesource.com/583965 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#489249} [modify] https://crrev.com/1da3e650170117d8d5173fa0ed2f32d40424c3a6/ui/file_manager/file_manager/foreground/js/file_tasks.js
,
Jul 25 2017
,
Jul 25 2017
,
Jul 25 2017
Issue 748181 has been merged into this issue.
,
Jul 26 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 31 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41c5f8fab7947375297f21b0a9a33831c79de548 commit 41c5f8fab7947375297f21b0a9a33831c79de548 Author: Naoki Fukino <fukino@chromium.org> Date: Tue Aug 01 01:48:51 2017 Files app: Fix condition to remove existing share-related items. Share items except for <cr-menu-item command="#share"> should be cleared when we re-create the share options menu, but the condition was wrong and existing items were not removed correctly. TBR=fukino@chromium.org (cherry picked from commit 1da3e650170117d8d5173fa0ed2f32d40424c3a6) Bug: 747200 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8e61f9ec65176cd4f21bdcf8b9102db0695b1063 Reviewed-on: https://chromium-review.googlesource.com/583965 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489249} Reviewed-on: https://chromium-review.googlesource.com/595287 Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#203} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/41c5f8fab7947375297f21b0a9a33831c79de548/ui/file_manager/file_manager/foreground/js/file_tasks.js
,
Aug 5 2017
Verified on M62 (Chrome OS 9807.0.0, 62.0.3176.0 dev build). |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by sdantul...@chromium.org
, Jul 21 2017