New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747195 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Cancel download button in confirmation dialog not working when closing a window

Project Member Reported by tetsui@chromium.org, Jul 21 2017

Issue description

Chrome Version: ToT (518e065e3341870945e618e70d0f8058061ba9a7)
OS: ChromeOS

What steps will reproduce the problem?
(1) Start downloading a file e.g. http://ipv4.download.thinkbroadband.com/1GB.zip
(2) Close the browser window by close button in the upper right. "Download in progress" dialog shows up.
(3) Click the "Cancel dialog" button in the dialog.

What is the expected result?
Download should be cancelled, or the dialog should not show up from the first.

What happens instead?
Download is not cancelled.
 

Comment 1 by tetsui@chromium.org, Jul 25 2017

Owner: tetsui@chromium.org
Status: Started (was: Untriaged)

Comment 2 by tetsui@chromium.org, Jul 25 2017

Owner: rdsmith@chromium.org
Status: Untriaged (was: Started)
rdsmith@: Could you take a look at it?

I'm not familiar with Chrome's window and process management, but what I imagined 
for the cause of the bug is:
* Chrome aborts all the downloads when all the processes are quit.
* Chrome shows the "Download in progress" dialog when closing the last window if it has pending downloads.
* On other OSes, closing the last window quits all the processes. In Chrome OS, it isn't.

FYI: I wrote a patch to remove the dialog form Chrome OS, though not sure if this is the expected behavior. Maybe aborting downloads also in Chrome OS might be appropriate.
https://chromium-review.googlesource.com/c/583956
Cc: rdsmith@chromium.org
Owner: dtrainor@chromium.org
I'm no longer working on downloads.  David, are you an appropriate person to lateral this bug to?

Cc: qin...@chromium.org dah...@chromium.org
Status: Assigned (was: Untriaged)
Yes I am thanks!  Will take a look.

Is there a difference between "Browser shutdown" and "all windows closing" on ChromeOS?  Because it seems like the expectation is that when all windows are closed the Profile is destroyed, which requires us to show this notification.  But from what you're saying it looks like that isn't the case (which makes sense if you've logged in and just closed all windows).
Labels: M-62

Comment 6 by tetsui@chromium.org, Jul 27 2017

Thank you for taking a look at it!

> Because it seems like the expectation is that when all windows are closed the Profile is destroyed, which requires us to show this notification.  But from what you're saying it looks like that isn't the case (which makes sense if you've logged in and just closed all windows).

I logged in and just closed all windows.
I guess the alternative UI would be to show the dialog when you log out.  Either that or we make that dialog actually cancel the downloads.
Cc: -rdsmith@chromium.org

Sign in to add a comment