Cancel download button in confirmation dialog not working when closing a window |
||||||
Issue descriptionChrome Version: ToT (518e065e3341870945e618e70d0f8058061ba9a7) OS: ChromeOS What steps will reproduce the problem? (1) Start downloading a file e.g. http://ipv4.download.thinkbroadband.com/1GB.zip (2) Close the browser window by close button in the upper right. "Download in progress" dialog shows up. (3) Click the "Cancel dialog" button in the dialog. What is the expected result? Download should be cancelled, or the dialog should not show up from the first. What happens instead? Download is not cancelled.
,
Jul 25 2017
rdsmith@: Could you take a look at it? I'm not familiar with Chrome's window and process management, but what I imagined for the cause of the bug is: * Chrome aborts all the downloads when all the processes are quit. * Chrome shows the "Download in progress" dialog when closing the last window if it has pending downloads. * On other OSes, closing the last window quits all the processes. In Chrome OS, it isn't. FYI: I wrote a patch to remove the dialog form Chrome OS, though not sure if this is the expected behavior. Maybe aborting downloads also in Chrome OS might be appropriate. https://chromium-review.googlesource.com/c/583956
,
Jul 25 2017
I'm no longer working on downloads. David, are you an appropriate person to lateral this bug to?
,
Jul 26 2017
Yes I am thanks! Will take a look. Is there a difference between "Browser shutdown" and "all windows closing" on ChromeOS? Because it seems like the expectation is that when all windows are closed the Profile is destroyed, which requires us to show this notification. But from what you're saying it looks like that isn't the case (which makes sense if you've logged in and just closed all windows).
,
Jul 26 2017
,
Jul 27 2017
Thank you for taking a look at it! > Because it seems like the expectation is that when all windows are closed the Profile is destroyed, which requires us to show this notification. But from what you're saying it looks like that isn't the case (which makes sense if you've logged in and just closed all windows). I logged in and just closed all windows.
,
Jul 27 2017
I guess the alternative UI would be to show the dialog when you log out. Either that or we make that dialog actually cancel the downloads.
,
Feb 16 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tetsui@chromium.org
, Jul 25 2017Status: Started (was: Untriaged)