New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747193 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

popup blocked after user initiated event

Reported by patrick....@sunpowercorp.com, Jul 21 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Steps to reproduce the problem:
1. Get to a page that uses Satellizer to open an OAuth window. 
2. In Angular, have an ng-click event on some tag that is supposed to open an OAuth popup
3. Click whatever it is you gave an ng-click event to.

What is the expected behavior?
The popup opens and is not blocked. That way you can enter your credentials for the other provider's website, and they callback my url in that window that then immediately window.close()s it so it runs my onClose event and turns off my spinner. 

What went wrong?
It got blocked, making my spinner run forever. I thought all user initiated popups, i.e. with an actual click, weren't supposed to be blocked. What's up with that?

Did this work before? Yes Whichever was before this one. 

Does this work in other browsers? Yes

Chrome version: 59.0.3071.115  Channel: stable
OS Version: OS X 10.12.5
Flash Version: 

The GitHub for Satellizer is https://github.com/sahat/satellizer
I'm using a pretty vanilla Angular and Satellizer setup so I apologize for the lack of test cases. I have people angry at me for these popups not displaying and it's irritating because this was working without a hitch last week when we had QA testing done.
 
I forgot to add that if you open the popup anyway by clicking the blue link in the  popup blocker dialog, it will appear to run correctly but then it never calls the onClose event from the original window so the spinner continues to go anyway.
popups_blocked.png
573 KB View Download
Labels: Needs-Triage-M59 Needs-Bisect
Cc: krajshree@chromium.org
Components: UI>Browser>PopupBlocker
Labels: Needs-Feedback
patrick.westmeyer@ - Thanks for filing the issue...!!

Tried testing the issue on Mac 10.12.5 by navigating to URL: 
https://monitor.us.sunpower.com/#/dashboard as shown in the attached screen shot and also by downloading the satellizer from the URL: https://github.com/sahat/satellizer.
But opening the URL: https://monitor.us.sunpower.com/#/dashboard asked for valid credentials and on downloading satellizer-master, did not find any sample URL or html file to test the issue.

patrick.westmeyer@ - Could you please provide sample credentials for URL: https://monitor.us.sunpower.com/#/dashboard or any other sample html file to triage the issue from TE-end.

Thanks...!!

Comment 5 by tapted@chromium.org, Aug 28 2017

Owner: csharrison@chromium.org
[mac triage] Maybe related to stuff in  Issue 756089 ?
Status: Assigned (was: Unconfirmed)
We shouldn't be enabling the stronger popup blocker yet, so it shouldn't be related to  issue 756089  (if it is, it's a bug).

Patrick, does this easily reproduce for you on the latest Chrome stable (M60)? Could also potentially be related to user gesture refactorings.

Comment 7 by jochen@chromium.org, Aug 28 2017

note that it's not enough that the user initiated the event, but the popup also has to be open in response to that event. So if your page captures the event and then fires a synthetic event at the site, it won't work.
csharrison@ - Gentle Ping...!!
Could you please provide any update on the issue.

Thanks...!!
krajshree: Seems like we're waiting on a repro from Patrick here.
Labels: -Needs-Bisect
Removing from the bisect queue since there is no valid updates for reproducing.
Status: Archived (was: Assigned)
Marking as Archived due to lack of feedback. Patrick please open a new issue if this is still affecting you.

Sign in to add a comment