New issue
Advanced search Search tips

Issue 747162 link

Starred by 1 user
Status: Fixed
Owner:
mdjones@chromium.org
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Remove extra SetBottomControlsHeight in layer_tree_host

Project Member Reported by mdjones@chromium.org, Jul 20 2017 
Recent changes merge the setter for top and bottom controls: https://chromium-review.googlesource.com/c/560641/

The call to set bottom controls by itself should be removed:

https://cs.chromium.org/chromium/src/cc/trees/layer_tree_host.h?rcl=c30954c57b331427516ec6ca136b1310b094cd30&l=293
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02d32b9bc5c2412db78360fed739dbef15ef5882

commit 02d32b9bc5c2412db78360fed739dbef15ef5882
Author: Matthew Jones <mdjones@chromium.org>
Date: Thu Jul 27 16:40:55 2017

Remove unnecessary SetBottomControlsHeight from LayerTreeHost

SetBrowserControlsHeight now handles bottom controls, so having an
explicit setter for it is unnecessary.

BUG= 747162 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibd247d7e6b3e1db3f6ca56a42fa8e2f5027bdefc
Reviewed-on: https://chromium-review.googlesource.com/587349
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489972}
[modify] https://crrev.com/02d32b9bc5c2412db78360fed739dbef15ef5882/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/02d32b9bc5c2412db78360fed739dbef15ef5882/cc/trees/layer_tree_host.h
[modify] https://crrev.com/02d32b9bc5c2412db78360fed739dbef15ef5882/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/02d32b9bc5c2412db78360fed739dbef15ef5882/content/renderer/gpu/render_widget_compositor.h
[modify] https://crrev.com/02d32b9bc5c2412db78360fed739dbef15ef5882/content/renderer/render_widget.cc

Comment 2 by mdjones@chromium.org, Jul 27 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment