Issue metadata
Sign in to add a comment
|
Data merge warning not displayed when switching between accounts |
||||||||||||||||||||||||
Issue descriptionENVIRONMENT and STATS Chrome version: 61.0.3160.0 Channel: dev OS Version: 7.1.1 REPRO STEPS 1. Add two accounts to Chrome. 2. Sign in to Chrome with account A. 3. Sign out 4. Sign in and select account B in the sign in screen ACTUAL RESULTS Sync confirmation screen is displayed EXPECTED RESULTS Account merge warning dialog is displayed. Note: This is a regression in 61.0.3160.0. Working fine in 61.0.3142.0
,
Jul 24 2017
This issue has the same bisect range as issue 747155 . Good build: 61.0.3157.3 Bad build: 61.0.3158.0 CL range: https://chromium.googlesource.com/chromium/src/+log/61.0.3157.0..61.0.3158.0?pretty=fuller&n=10000 msramek@ - Can you please take a look?
,
Jul 24 2017
Likely seems related to Martin's change.
,
Jul 25 2017
Not just the same regression range, also the same underlying problem as issue 747155 . Waiting for code review in https://chromium-review.googlesource.com/c/581497/, which fixes this issue as well. The problem was that the service worker cache deletion reused the same callback path as the complete data deletion, which resulted in supressing this warning dialog.
,
Jul 25 2017
Fixed as part of issue 747155 , will merge this once it's verified in Canary.
,
Jul 25 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
,
Jul 25 2017
Although it's not literally the same issue, I'm marking as duplicate to make it formally clear that the two share a common fix.
,
Jul 25 2017
Removing Merge-TBD since issue 747155 is tracking the CL that will need to be merged already. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by zea@chromium.org
, Jul 20 2017