New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747130 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-Servicification


Sign in to add a comment

PlzNavigate should use mojo::URLLoader interface to talk to ResourceDispatcherHost

Project Member Reported by jam@chromium.org, Jul 20 2017

Issue description

Once NavigationRequest always talks to the network via mojo::URLLoader, then we can ship the new glue for various features that we're working on (i.e. safe browsing, appcache, service worker, download) before the network service is fully complete. This allows us to test these new pieces of code iteratively which is lower risk than all at once, and also avoids carrying multiple code paths for too long.

Camille is currently working on switching plznavigate to use data pipe, which is a prerequisite so I've put that as a blocking bug. Since you mentioned someone in PAR will look at this in Q3, assigned to you for now. Please reassign as necessar.

I've marked this bug as blocking the new glue that is being worked on.
 

Comment 1 by jam@chromium.org, Jul 21 2017

Blocking: 747176
Cc: michaeln@chromium.org

Comment 3 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 4 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 5 by laforge@google.com, Nov 8 2017

Components: Internals>Services>Storage
Setting Internals>Services>Storage to all children of issue 611938

Comment 6 by jam@chromium.org, Nov 8 2017

Components: -Internals>Services>Storage

Comment 7 by kinuko@chromium.org, Jan 11 2018

Looks like this is rather being worked on  issue 705744 ?

Comment 8 by jam@chromium.org, Jan 11 2018

@Kinuko yes it appears so. That child bug was initially just for the data pipe work, and this one for using URLLoader. I don't really care which bug is used :)
Blocking: 821557

Comment 10 by jam@chromium.org, May 1 2018

Cc: clamy@chromium.org
 Issue 740130  has been merged into this issue.

Comment 11 by jam@chromium.org, May 1 2018

Status: Fixed (was: Assigned)
Since NavigationMojoResponse is now always used. Thanks!
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afa62a0814c5443abdb3e93eb9bc4914273d2549

commit afa62a0814c5443abdb3e93eb9bc4914273d2549
Author: Egor Pasko <pasko@chromium.org>
Date: Mon Jun 18 14:56:00 2018

URLLoaderInterceptor: remove mention of fixed bug

The  http://crbug.com/747130  is fixed, hence URLLoaderInterceptor should
work for frame requests - remove the obsolete comment. Also fix a typo
in a comment nearby. Seems like a typo to sincerely yours, non-native
speaker.

Bug:  747130 
Change-Id: I7d88a09ce459d69348c3751fae845b5152324dff
Reviewed-on: https://chromium-review.googlesource.com/1104431
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568004}
[modify] https://crrev.com/afa62a0814c5443abdb3e93eb9bc4914273d2549/content/public/test/url_loader_interceptor.h

Sign in to add a comment