New issue
Advanced search Search tips

Issue 747129 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Show the real rootfs failure reason when revert boot partition fails after update failed

Project Member Reported by dhadd...@chromium.org, Jul 20 2017

Issue description

We are showing failures to revert the boot partition after the update fails. It looks something like this:

	
Unhandled DevServerException: CrOS auto-update failed for host chromeos6-row2-rack4-host1: cmd=['ssh', '-p', '22', '-oConnectionAttempts=4', '-oUserKnownHostsFile=/dev/null', '-oProtocol=2', '-oConnectTimeout=30', '-oServerAliveCountMax=3', '-oStrictHostKeyChecking=no', '-oServerAliveInterval=10', '-oNumberOfPasswordPrompts=0', '-oIdentitiesOnly=yes', '-i', '/tmp/ssh-tmpGd4vV6/testing_rsa', 'root@chromeos6-row2-rack4-host1', '--', '/postinst', '/dev/sda3'], extra env={'LC_MESSAGES': 'C'}


This does not help us understand the failure
 
Cc: xixuan@chromium.org
I want to hide this failure and raise the actual error that happened during the update. 
Status: Started (was: Untriaged)
Summary: Show the real rootfs failure reason when revert boot partition fails after update failed (was: Show the real rootfs failure reason when revert boot partition fails)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/94a03aa09789c2e80875939656489c80c3668563

commit 94a03aa09789c2e80875939656489c80c3668563
Author: David Haddock <dhaddock@chromium.org>
Date: Fri Jul 21 04:21:24 2017

Show the real reason for Rootfs failure.

When the rootfs update fails to update during the AU test, reverting the
boot partition sometimes also fails. This boot partition revert exception is
not caught and so we raise this error instead of the rootfs error.

This makes debugging failures in canaries very difficult.
This fixes that.

BUG= chromium:747129 
TEST=autoupdate_EndToEndTest

Change-Id: Ifafae39e14891fb16871a4ce863fa269037721dc
Reviewed-on: https://chromium-review.googlesource.com/580502
Commit-Ready: David Haddock <dhaddock@chromium.org>
Tested-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/94a03aa09789c2e80875939656489c80c3668563/lib/auto_updater.py

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Labels: FixedByAURewrite

Sign in to add a comment