Chrome Cleanup WebUI UI fixes |
||||||
Issue descriptionUI Review had a few suggestions to improve the Chrome Cleanup WebUI: * Standardize use of colors for the icons * Use a smaller spinner and icons * Use an "ok" icon instead of an "error" icon for the reboot-required case. Someone else suggested: * Adding the "Learn more" link to the error state
,
Jul 26 2017
,
Jul 27 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 27 2017
Pls merge you change to M61 branch 3163 by 5:00 PM today, Thursday if possible so we can take it in for next week M61 last dev release. Thank you.
,
Jul 27 2017
Thank you, I'll get started on the merge right away
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5a3466d6a171f7ed4cb6c6e01e0b4bb68f9a9af commit a5a3466d6a171f7ed4cb6c6e01e0b4bb68f9a9af Author: proberge <proberge@chromium.org> Date: Thu Jul 27 17:58:43 2017 Chrome Cleanup WebUI: polishing fixes from implementation review Resize spinner, standardize color use, add learn more to error state, change reboot required icon Also makes chrome://settings/help use the right colors. Bug: 747124 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifae6b61cc4ffa668dbe095333f3590a2d97277a4 Reviewed-on: https://chromium-review.googlesource.com/580360 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#488992} (cherry picked from commit 435ed1848ee5bf092fcbfd818b9f49e98c1485a1) Change-Id: I6f20ec0a45aec8f19e4df42921a994567576c7d9 Reviewed-on: https://chromium-review.googlesource.com/590349 Reviewed-by: proberge <proberge@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#85} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/a5a3466d6a171f7ed4cb6c6e01e0b4bb68f9a9af/chrome/browser/resources/settings/about_page/about_page.html [modify] https://crrev.com/a5a3466d6a171f7ed4cb6c6e01e0b4bb68f9a9af/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html [modify] https://crrev.com/a5a3466d6a171f7ed4cb6c6e01e0b4bb68f9a9af/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
,
Jul 27 2017
,
Aug 1 2017
@proberge: Could you please provide us the sample repro steps to check the issue from our end? Thanks!!
,
Aug 1 2017
Hi Sandeep, I sent you a document with instructions over e-mail.
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5037cfe0bde9c0bbba1e6366ee8c86f88607324 commit a5037cfe0bde9c0bbba1e6366ee8c86f88607324 Author: proberge <proberge@chromium.org> Date: Wed Aug 16 20:42:29 2017 Chrome Cleanup WebUI: update CSS/trademark symbol for new partner logo In https://chromereviews.googleplex.com/601907013/ we updated the chrome_cleanup_powered_by_company.svg to have the trademark symbol in the image itself. The svg also has some extra padding around the logo, so we need to increase the image size to get it to show at the same size as before. Bug: 747124 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7a5797c43421339df6d1355165887a20b55365ce Reviewed-on: https://chromium-review.googlesource.com/611153 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#494934} [modify] https://crrev.com/a5037cfe0bde9c0bbba1e6366ee8c86f88607324/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html [modify] https://crrev.com/a5037cfe0bde9c0bbba1e6366ee8c86f88607324/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cef9dfdc327a3985d65000285b38090ebc6ed3ae commit cef9dfdc327a3985d65000285b38090ebc6ed3ae Author: proberge <proberge@chromium.org> Date: Thu Aug 17 19:29:39 2017 Chrome Cleanup WebUI: Add period to error string, inline learn more From @bettes: it'd be great to have the Learn more appear on the same line, rather than on the secondary line. Bug: 747124 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6047f8ca9d03e9334b1dcd1b936711ca19b5443b Reviewed-on: https://chromium-review.googlesource.com/612368 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#495279} [modify] https://crrev.com/cef9dfdc327a3985d65000285b38090ebc6ed3ae/chrome/app/generated_resources.grd [modify] https://crrev.com/cef9dfdc327a3985d65000285b38090ebc6ed3ae/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jul 24 2017