Roll EarlGrey to 1.10.1 |
||
Issue descriptionThis is a preparation step for iOS 11, and should allow an easier roll to the version that contains iOS 11 fixes once it's released.
,
Jul 20 2017
Right now, this is blocked by some broken showcase eg tests, and the fix is in flight: https://chromium-review.googlesource.com/c/580357.
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17aced1485e54a55ab1a1473650c5325b2158e45 commit 17aced1485e54a55ab1a1473650c5325b2158e45 Author: Yuke Liao <liaoyuke@chromium.org> Date: Thu Jul 20 21:37:33 2017 Make showcase home screen not translucent. EarlGrey 1.10.1 has a bug that the scrollToTop action hangs indefinitely if the UITableView's navigation bar is translucent. Given that it makes no difference whether the view is translucent or not, this CL makes it not translucent to unblock rolling EarlGrey to 1.10.1. Bug: 747116 Change-Id: Idd48cf6f3f024c4b88bedcca412692598cd1a493 Reviewed-on: https://chromium-review.googlesource.com/580357 Reviewed-by: Ed Chin <edchin@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#488417} [modify] https://crrev.com/17aced1485e54a55ab1a1473650c5325b2158e45/ios/showcase/core/showcase_view_controller.mm [modify] https://crrev.com/17aced1485e54a55ab1a1473650c5325b2158e45/ios/showcase/tools_menu/sc_tools_coordinator.mm
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1201acfa9f8ac3e61b67cfddc76a46324380634d commit 1201acfa9f8ac3e61b67cfddc76a46324380634d Author: Yuke Liao <liaoyuke@chromium.org> Date: Thu Jul 20 22:31:18 2017 Revert "Make showcase home screen not translucent." This reverts commit 17aced1485e54a55ab1a1473650c5325b2158e45. Reason for revert: I only tested on iPhone 7, however, it seems that testNavigationByTappingReturn is broken on iPhone 5s. I'm going to investigate and then reland. Sorry for the inconvenience. Original change's description: > Make showcase home screen not translucent. > > EarlGrey 1.10.1 has a bug that the scrollToTop action hangs > indefinitely if the UITableView's navigation bar is translucent. Given > that it makes no difference whether the view is translucent or not, > this CL makes it not translucent to unblock rolling EarlGrey to 1.10.1. > > Bug: 747116 > Change-Id: Idd48cf6f3f024c4b88bedcca412692598cd1a493 > Reviewed-on: https://chromium-review.googlesource.com/580357 > Reviewed-by: Ed Chin <edchin@chromium.org> > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488417} TBR=edchin@chromium.org,liaoyuke@chromium.org Change-Id: I2669a23928d1f4ce230bb25bd852a6f441019f17 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 747116 Reviewed-on: https://chromium-review.googlesource.com/580194 Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#488446} [modify] https://crrev.com/1201acfa9f8ac3e61b67cfddc76a46324380634d/ios/showcase/core/showcase_view_controller.mm [modify] https://crrev.com/1201acfa9f8ac3e61b67cfddc76a46324380634d/ios/showcase/tools_menu/sc_tools_coordinator.mm
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79ed387ca6cc60566739c9bba268ef767b499f12 commit 79ed387ca6cc60566739c9bba268ef767b499f12 Author: Yuke Liao <liaoyuke@chromium.org> Date: Fri Jul 21 18:41:09 2017 Reland "Make showcase home screen not translucent." This relands "Make showcase home screen not translucent.". Original change's description: > Make showcase home screen not translucent. > > EarlGrey 1.10.1 has a bug that the scrollToTop action hangs > indefinitely if the UITableView's navigation bar is translucent. Given > that it makes no difference whether the view is translucent or not, > this CL makes it not translucent to unblock rolling EarlGrey to 1.10. Bug: 747116 Change-Id: I9c3af1633aac27439734925c142f8a684eeb9658 Reviewed-on: https://chromium-review.googlesource.com/580341 Reviewed-by: Ed Chin <edchin@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#488718} [modify] https://crrev.com/79ed387ca6cc60566739c9bba268ef767b499f12/ios/showcase/core/showcase_view_controller.mm [modify] https://crrev.com/79ed387ca6cc60566739c9bba268ef767b499f12/ios/showcase/payments/sc_payments_editor_egtest.mm [modify] https://crrev.com/79ed387ca6cc60566739c9bba268ef767b499f12/ios/showcase/tools_menu/sc_tools_coordinator.mm
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3a052a1793ecb4e2ca9ee7119acce20024d8402 commit b3a052a1793ecb4e2ca9ee7119acce20024d8402 Author: Yuke Liao <liaoyuke@chromium.org> Date: Fri Jul 21 23:38:32 2017 Roll EarlGrey to f456370981a612d73eb79df7acf3e7303755e160. This CL rolls EarlGrey to f456370981a612d73eb79df7acf3e7303755e160 to pick up the latest changes and prepare for iOS 11. BUG= 747116 Change-Id: Idf15fe28e124e99f99740fdee0b79e9de969e406 Reviewed-on: https://chromium-review.googlesource.com/581930 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Mike Baxley <baxley@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#488796} [modify] https://crrev.com/b3a052a1793ecb4e2ca9ee7119acce20024d8402/DEPS [modify] https://crrev.com/b3a052a1793ecb4e2ca9ee7119acce20024d8402/ios/third_party/earl_grey/BUILD.gn
,
Jul 21 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by liaoyuke@chromium.org
, Jul 20 2017