New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747112 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add way to retrieve the servo_micro serial number from behind a servo_v4.

Project Member Reported by aaboagye@chromium.org, Jul 20 2017

Issue description

The test lab uses/plans to use a servo_v4 and servo_micro connected to the servo_v4. For programmatically updating the EC firmware on DUTs, the flash_ec script needs to be able to determine the serial number of the servo_micro connected to the servo_v4. Currently, the script obtains the serial number of the servo_v4 and flashing fails.

We should probably add a new control for this servo_v4 + servo_micro case which will expose the servo_micro serial number for flashing purposes.
 
Also need to expose cr50 serial number in servo_v4 -> cr50 case.
Status: Started (was: Assigned)
hdctools patchset ends here: https://chromium-review.googlesource.com/c/597209
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/a9fee38b9d36d24e28613999507875c75c10a5f2

commit a9fee38b9d36d24e28613999507875c75c10a5f2
Author: Aseda Aboagye <aaboagye@google.com>
Date: Wed Aug 02 17:13:33 2017

servo: Change micro_servo to servo_micro.

Just transpose the words to make things consistent.

BUG= chromium:747112 
TEST=servod starts up okay.

Change-Id: Ib5f21521f4d1404683dffeabd280f2725395b988
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/597208
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Mary Ruthven <mruthven@chromium.org>

[modify] https://crrev.com/a9fee38b9d36d24e28613999507875c75c10a5f2/servo/servo_postinit.py
[modify] https://crrev.com/a9fee38b9d36d24e28613999507875c75c10a5f2/servo/servo_server.py

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/6921f600c9cc243f3e690e8f579cc795e9140924

commit 6921f600c9cc243f3e690e8f579cc795e9140924
Author: Aseda Aboagye <aaboagye@google.com>
Date: Wed Aug 02 17:13:33 2017

servo: Add get_serial_name() method.

This commit adds a method that will allow the various connected servos' serial
numbers to be retrieved.

BUG= chromium:747112 
TEST=sudo emerge hdctools; `dut-control serialname` returns the main
servo serial number.  With a servo v4 with a servo micro connected to
it, verify that `dut-control servo_micro_serialname` retrives the serial
number of the servo micro.

Change-Id: I15f03dfe56f0becc549fa7258b102982605465fb
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/597209
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Mary Ruthven <mruthven@chromium.org>

[modify] https://crrev.com/6921f600c9cc243f3e690e8f579cc795e9140924/servo/servo_postinit.py
[modify] https://crrev.com/6921f600c9cc243f3e690e8f579cc795e9140924/servo/servo_server.py

Status: Verified (was: Started)
Verified locally in CL.

Sign in to add a comment