New issue
Advanced search Search tips

Issue 747103 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

GAIA screen should have rounded corners on the top

Project Member Reported by elizabethchiu@chromium.org, Jul 20 2017

Issue description

The OOBE screen for GAIA is missing the rounded corners on the top. The radius of the corners should be 2dp.


 
Screen Shot 2017-07-20 at 1.23.32 PM.png
19.8 KB View Download
IMG_9645.JPG
728 KB View Download
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/734af4879ae28fa14c5dd97358be8a4ebab925dd

commit 734af4879ae28fa14c5dd97358be8a4ebab925dd
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Jul 21 01:48:24 2017

Chromeos: use rounded border for Gaia frame.

This CL makes Gaia screen match other OOBE screens design.

Bug:  747103 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idfb6b58ce7d7721b4a33856280d1123165be4247
Reviewed-on: https://chromium-review.googlesource.com/580615
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488542}
[modify] https://crrev.com/734af4879ae28fa14c5dd97358be8a4ebab925dd/chrome/browser/resources/chromeos/login/screen_gaia_signin.css

Status: Fixed (was: Started)
Labels: Merge-Request-61
Please add appropriate OSs.
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 25 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: OS-Chrome
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 26 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea2ad3fafb108917c5c644c7a275e0dc69f71335

commit ea2ad3fafb108917c5c644c7a275e0dc69f71335
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Jul 26 03:03:11 2017

Chromeos: use rounded border for Gaia frame.

This CL makes Gaia screen match other OOBE screens design.

TBR=alemate@chromium.org

(cherry picked from commit 734af4879ae28fa14c5dd97358be8a4ebab925dd)

Bug:  747103 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idfb6b58ce7d7721b4a33856280d1123165be4247
Reviewed-on: https://chromium-review.googlesource.com/580615
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488542}
Reviewed-on: https://chromium-review.googlesource.com/585674
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#49}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/ea2ad3fafb108917c5c644c7a275e0dc69f71335/chrome/browser/resources/chromeos/login/screen_gaia_signin.css

Cc: mkarkada@chromium.org dhadd...@chromium.org
Status: Verified (was: Fixed)
Verified on M61 (Chrome OS 9765.16.0, 61.0.3163.30 dev build).

Sign in to add a comment