Need to add localization support to the app.
CL https://chromium-review.googlesource.com/c/578187/ belongs to this bug.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb41e828587ee40985cdb90908ae1a08e9fdc9dc commit fb41e828587ee40985cdb90908ae1a08e9fdc9dc Author: Yuwei Huang <yuweih@chromium.org> Date: Thu Jul 20 23:23:29 2017 [CRD iOS] Add more texts to be localized for the client This CL moves some hardcoded texts into remoting_string.grd so that they can be localized. Bug: 747091 Change-Id: Id9f57bd7d48338635d2c7d0567df1b8e24a83b0b Reviewed-on: https://chromium-review.googlesource.com/578949 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Scott Nichols <nicholss@chromium.org> Cr-Commit-Position: refs/heads/master@{#488479} [modify] https://crrev.com/fb41e828587ee40985cdb90908ae1a08e9fdc9dc/remoting/ios/app/app_delegate.mm [modify] https://crrev.com/fb41e828587ee40985cdb90908ae1a08e9fdc9dc/remoting/ios/app/client_connection_view_controller.mm [modify] https://crrev.com/fb41e828587ee40985cdb90908ae1a08e9fdc9dc/remoting/ios/app/help_view_controller.mm [modify] https://crrev.com/fb41e828587ee40985cdb90908ae1a08e9fdc9dc/remoting/ios/app/host_collection_view_cell.mm [modify] https://crrev.com/fb41e828587ee40985cdb90908ae1a08e9fdc9dc/remoting/ios/app/host_collection_view_controller.mm [modify] https://crrev.com/fb41e828587ee40985cdb90908ae1a08e9fdc9dc/remoting/ios/app/host_view_controller.mm [modify] https://crrev.com/fb41e828587ee40985cdb90908ae1a08e9fdc9dc/remoting/ios/app/pin_entry_view.mm [modify] https://crrev.com/fb41e828587ee40985cdb90908ae1a08e9fdc9dc/remoting/ios/app/remoting_menu_view_controller.mm [modify] https://crrev.com/fb41e828587ee40985cdb90908ae1a08e9fdc9dc/remoting/ios/app/settings/remoting_settings_view_controller.mm [modify] https://crrev.com/fb41e828587ee40985cdb90908ae1a08e9fdc9dc/remoting/ios/app/user_status_presenter.mm [modify] https://crrev.com/fb41e828587ee40985cdb90908ae1a08e9fdc9dc/remoting/resources/remoting_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18600f3a80f58de4b0b3d22879883f5de6e034a5 commit 18600f3a80f58de4b0b3d22879883f5de6e034a5 Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Jul 21 18:20:08 2017 [CRD iOS] I18N for the host setup view Add i18n support for the host setup view. Also add missing strings in the settings menu. Bug: 747091 Change-Id: Ideea85dc2d0d9933e39bfe9c6e9a1b00a190291c Reviewed-on: https://chromium-review.googlesource.com/580729 Reviewed-by: Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#488711} [modify] https://crrev.com/18600f3a80f58de4b0b3d22879883f5de6e034a5/remoting/ios/app/host_setup_footer_view.mm [modify] https://crrev.com/18600f3a80f58de4b0b3d22879883f5de6e034a5/remoting/ios/app/host_setup_header_view.mm [modify] https://crrev.com/18600f3a80f58de4b0b3d22879883f5de6e034a5/remoting/ios/app/host_setup_view_controller.mm [modify] https://crrev.com/18600f3a80f58de4b0b3d22879883f5de6e034a5/remoting/ios/app/settings/remoting_settings_view_controller.mm [modify] https://crrev.com/18600f3a80f58de4b0b3d22879883f5de6e034a5/remoting/resources/remoting_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ef09342e8b813b9958a232e3a29e11c42687f8f commit 7ef09342e8b813b9958a232e3a29e11c42687f8f Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Jul 24 20:11:46 2017 [CRD iOS] Use placeholder for the host installation link Since google.com/remotedesktop is not ready yet, let's just put a placeholder in host instruction and set it in the code so that it can be easily changed. Bug: 747091 Change-Id: I1fa99580f1892f4b51c7eeb5cd3f6d954e00c430 Reviewed-on: https://chromium-review.googlesource.com/582027 Reviewed-by: Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#489061} [modify] https://crrev.com/7ef09342e8b813b9958a232e3a29e11c42687f8f/remoting/ios/app/host_setup_view_controller.mm [modify] https://crrev.com/7ef09342e8b813b9958a232e3a29e11c42687f8f/remoting/resources/remoting_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e01520c3d79a65ecb5b4536992a3c45ef9f709a4 commit e01520c3d79a65ecb5b4536992a3c45ef9f709a4 Author: Yuwei Huang <yuweih@chromium.org> Date: Tue Jul 25 01:04:10 2017 [CRD iOS] I18N for Info.plist This CL adds localization for InfoPlist. Basically the display name, product name, and copyright message. Also fixes some other strings of the app. Bug: 747091 Change-Id: Ia7a421182fc4f12350a7edf21630c525d5f9efda Reviewed-on: https://chromium-review.googlesource.com/582248 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Scott Nichols <nicholss@chromium.org> Cr-Commit-Position: refs/heads/master@{#489169} [modify] https://crrev.com/e01520c3d79a65ecb5b4536992a3c45ef9f709a4/remoting/branding_Chrome [modify] https://crrev.com/e01520c3d79a65ecb5b4536992a3c45ef9f709a4/remoting/branding_Chromium [modify] https://crrev.com/e01520c3d79a65ecb5b4536992a3c45ef9f709a4/remoting/ios/app/BUILD.gn [modify] https://crrev.com/e01520c3d79a65ecb5b4536992a3c45ef9f709a4/remoting/ios/app/resources/BUILD.gn [add] https://crrev.com/e01520c3d79a65ecb5b4536992a3c45ef9f709a4/remoting/ios/app/resources/InfoPlist.strings.jinja2 [modify] https://crrev.com/e01520c3d79a65ecb5b4536992a3c45ef9f709a4/remoting/ios/app/resources/Remoting.entitlements [modify] https://crrev.com/e01520c3d79a65ecb5b4536992a3c45ef9f709a4/remoting/remoting_locales.gni [modify] https://crrev.com/e01520c3d79a65ecb5b4536992a3c45ef9f709a4/remoting/resources/remoting_strings.grd
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/remoting/tools/internal/+/145ae8eb4e2a917e5ed2871ef15de0efe2ade302 commit 145ae8eb4e2a917e5ed2871ef15de0efe2ade302 Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Jul 28 20:16:47 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6b801a2005fc5b39942c24f5e6de3c4f8f45f34 commit b6b801a2005fc5b39942c24f5e6de3c4f8f45f34 Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Aug 04 18:07:49 2017 [CRD iOS] Add some AppStore metadata texts This CL adds AppStore metadata texts for the app's title, keyword, and description. Bug: 747091 Change-Id: I622c865e94660c224dc801411ad8b575b18eed7a Reviewed-on: https://chromium-review.googlesource.com/601412 Reviewed-by: Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#492068} [modify] https://crrev.com/b6b801a2005fc5b39942c24f5e6de3c4f8f45f34/remoting/resources/remoting_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2e5ad19b2fb89f7f84da0f8d87549c2da64f16d commit c2e5ad19b2fb89f7f84da0f8d87549c2da64f16d Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Aug 04 23:39:26 2017 [CRD iOS] Add localization for RemotingService errors Added localization for network error and authentication error in RemotingService. Bug: 747091 Change-Id: Ie6d7e52c9ace83e79ffb6a80b156d668edadb3af Reviewed-on: https://chromium-review.googlesource.com/600525 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Scott Nichols <nicholss@chromium.org> Cr-Commit-Position: refs/heads/master@{#492174} [modify] https://crrev.com/c2e5ad19b2fb89f7f84da0f8d87549c2da64f16d/remoting/ios/app/remoting_view_controller.mm [modify] https://crrev.com/c2e5ad19b2fb89f7f84da0f8d87549c2da64f16d/remoting/ios/facade/remoting_service.h [modify] https://crrev.com/c2e5ad19b2fb89f7f84da0f8d87549c2da64f16d/remoting/ios/facade/remoting_service.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a59329abc1775de0cebd7e1622accec6b3bf9a4 commit 7a59329abc1775de0cebd7e1622accec6b3bf9a4 Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Sep 11 22:31:43 2017 [CRD iOS] Break host setup instruction bullet points into multiple messages Previously we put all three steps into the same messages and split the string into multiple bullets by newline in the code. It seems this causes some confusions for the translators (they just don't break the line properly to match three bullet points). This CL breaks the setup message into separate messages for each step to minimize confusion to the translators. Bug: 747091 Change-Id: I95e1d2cd0bae775e93b1b22bf8937a09f987d797 Reviewed-on: https://chromium-review.googlesource.com/660663 Reviewed-by: Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#501067} [modify] https://crrev.com/7a59329abc1775de0cebd7e1622accec6b3bf9a4/remoting/ios/app/host_setup_view_controller.mm [modify] https://crrev.com/7a59329abc1775de0cebd7e1622accec6b3bf9a4/remoting/resources/remoting_strings.grd
Comment 1 by yuweih@chromium.org
, Jul 20 2017