New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
no longer active
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment
link

Issue 747082: Throw NotSupportedError DomException when playbackRate is unsupported.

Reported by apaci...@chromium.org, Jul 20 2017 Project Member

Issue description

Change to the standard:
https://github.com/whatwg/html/pull/2829

Rendered: search for "the playbackRate attribute gives" in https://html.spec.whatwg.org/multipage/media.html#playing-the-media-resource

Change to tests: https://github.com/w3c/web-platform-tests/pull/6522

Note: this is a change that all browsers need to make.
 

Comment 1 by apaci...@chromium.org, Sep 12 2017

Status: Started (was: Assigned)

Comment 2 by bugdroid1@chromium.org, Oct 17 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12d98c254b1c715ec1bae498ac730b2b2fe5469e

commit 12d98c254b1c715ec1bae498ac730b2b2fe5469e
Author: Jennifer Apacible <apacible@chromium.org>
Date: Tue Oct 17 06:09:29 2017

Throw an exception if media playbackRate is out of range.

Intent to implement/ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/a0tguvcZZyk

BUG:  747082 
Change-Id: I740aa8396a7cecc74b741ab544c71652121c44d3
Reviewed-on: https://chromium-review.googlesource.com/666121
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509282}
[modify] https://crrev.com/12d98c254b1c715ec1bae498ac730b2b2fe5469e/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/12d98c254b1c715ec1bae498ac730b2b2fe5469e/third_party/WebKit/LayoutTests/media/media-ended.html
[modify] https://crrev.com/12d98c254b1c715ec1bae498ac730b2b2fe5469e/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp
[modify] https://crrev.com/12d98c254b1c715ec1bae498ac730b2b2fe5469e/third_party/WebKit/Source/core/html/media/HTMLMediaElement.h
[modify] https://crrev.com/12d98c254b1c715ec1bae498ac730b2b2fe5469e/third_party/WebKit/Source/core/html/media/HTMLMediaElement.idl
[modify] https://crrev.com/12d98c254b1c715ec1bae498ac730b2b2fe5469e/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/12d98c254b1c715ec1bae498ac730b2b2fe5469e/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/12d98c254b1c715ec1bae498ac730b2b2fe5469e/tools/metrics/histograms/enums.xml

Comment 3 by bugdroid1@chromium.org, Oct 20 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e8640ef2559184ce1022caa134a2398a7a30c57

commit 9e8640ef2559184ce1022caa134a2398a7a30c57
Author: Jennifer Apacible <apacible@chromium.org>
Date: Fri Oct 20 03:20:34 2017

Clamp values for playbackRate in HTMLMediaElement.

Previous change removed clamping for non-experimental case.

Bug:  775504 ,  775504 ,  775829 ,  775501 ,  747082 
Change-Id: I90eec1b3e99b2370ccd05669c3160399ca235bbc
Reviewed-on: https://chromium-review.googlesource.com/727119
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510318}
[modify] https://crrev.com/9e8640ef2559184ce1022caa134a2398a7a30c57/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/9e8640ef2559184ce1022caa134a2398a7a30c57/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp

Comment 4 by apaci...@chromium.org, Oct 23 2017

Labels: Merge-Request-63 OS-Chrome OS-Linux OS-Mac OS-Windows
Requesting merge for both #2 and #3. These changes are purely to gather metrics.

Comment 5 by sheriffbot@chromium.org, Oct 24 2017

Project Member
Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 Deleted

Comment 7 by gov...@chromium.org, Oct 26 2017

Please merge your change to M63 branch 3239 by 4:00 PM PT, today (Thursday). Thank you.

Comment 8 by apaci...@chromium.org, Oct 27 2017

Labels: -Merge-Approved-63 merge-merged-3239
Status: Fixed (was: Started)
Merged here:

https://chromium-review.googlesource.com/c/chromium/src/+/740872
https://chromium-review.googlesource.com/c/chromium/src/+/740874

Didn't realize drover doesn't pull in the original patch message anymore, so linked the original patches after the fact and manually updating the labels..

Comment 9 by apaci...@chromium.org, Oct 27 2017

Status: Started (was: Fixed)

Comment 10 by mlamouri@chromium.org, Oct 30 2017

apacible@, you marked the CL as "Started" in comment #9. Was this on purpose?

Comment 11 by apaci...@chromium.org, Nov 17 2017

I plan to mark it fixed when the change is no longer in experimental.

Comment 12 by bugdroid1@chromium.org, Nov 20 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a34b99b70385b4dcf97b04f2c41e76e6ca3e314c

commit a34b99b70385b4dcf97b04f2c41e76e6ca3e314c
Author: Jennifer Apacible <apacible@chromium.org>
Date: Mon Nov 20 23:41:47 2017

Throw DomException when playbackRate is unsupported by default.

This turns on the change to throw a NotSupportedError
DomException when playbackRate is unsupported on stable.

Intent to implement/ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/a0tguvcZZyk/QJjO8R3WFgAJ

Bug:  747082 
Change-Id: I10cc98bb052172683dc5208914bc1b5aaecdd7ff
Reviewed-on: https://chromium-review.googlesource.com/777772
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Philip J├Ągenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517994}
[modify] https://crrev.com/a34b99b70385b4dcf97b04f2c41e76e6ca3e314c/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/a34b99b70385b4dcf97b04f2c41e76e6ca3e314c/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp
[modify] https://crrev.com/a34b99b70385b4dcf97b04f2c41e76e6ca3e314c/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Comment 13 by mlamouri@chromium.org, Nov 22 2017

Status: Fixed (was: Started)

Sign in to add a comment