Chrome Cleaner UI: Dialog should be closed if the cleaner controller leaves the infected state |
||||||||
Issue descriptionAfter the user is shown the dialog about removing harmful software, if something goes wrong with the communication between Chrome and Chrome Cleaner process or if the user interacts with the Chrome Cleaner's webui page from a different browser window, the dialog is no longer meaningful and should be closed. It is not a good user experience to continue seeing the dialog when the buttons will actually no longer perform any meaningful function.
,
Jul 24 2017
,
Jul 24 2017
,
Jul 24 2017
This change made it into version 62.0.3164.0. I have tested the fix on Canary (version 62.0.3165.0) and the fix works.
,
Jul 24 2017
,
Jul 25 2017
,
Jul 25 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 26 2017
Please merge your change to M61 branch #3163 before 4: 00 PM PT, Wednesday (07/26) in order to make it to last M61 dev release. Thank you.
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87fcab7b0e641287d255d235222693de248f923b commit 87fcab7b0e641287d255d235222693de248f923b Author: Ali Tofigh <alito@chromium.org> Date: Wed Jul 26 17:00:00 2017 Chrome Cleaner UI: Close dialog if the controller leaves the infected state. The Chrome Cleaner dialog is shown when unwanted software is found on the user's computer. Currently, if errors occur during communication with the Chrome Cleaner process or if the user starts the cleanup from the settings page from a different browser window, the modal dialog will remain open. With this CL, the modal dialog is closed by Chrome if the global ChromeCleanerController object leaves the infected state, either due to errors or user action on the webui card in the settings page. TBR=alito@chromium.org (cherry picked from commit f5baba98f14b59da707b769f2f78d2085e7c64c0) Bug: 747077 Change-Id: I3f8ed6288901aa3f9aaa2c2f108ca141fa3d0545 Reviewed-on: https://chromium-review.googlesource.com/578472 Commit-Queue: Ali Tofigh <alito@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Robert Shield <robertshield@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488782} Reviewed-on: https://chromium-review.googlesource.com/587107 Reviewed-by: Ali Tofigh <alito@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#60} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/chrome/browser/safe_browsing/BUILD.gn [rename] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc [add] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.h [rename] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win_unittest.cc [modify] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.h [modify] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.cc [modify] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h [modify] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.h [modify] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/chrome/browser/ui/browser_dialogs.h [modify] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/chrome/browser/ui/views/chrome_cleaner_dialog_browsertest_win.cc [modify] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/chrome/browser/ui/views/chrome_cleaner_dialog_win.cc [modify] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/chrome/browser/ui/views/chrome_cleaner_dialog_win.h [modify] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/chrome/test/BUILD.gn [modify] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/tools/metrics/histograms/enums.xml
,
Jul 26 2017
Fix was merged to branch 3163. I tested and verified the fix with a Google-branded build of branch 3163 post-merge. Marking this as fixed. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 21 2017