New issue
Advanced search Search tips

Issue 747074 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

During serialization of repeat function, line names are not merging and this makes the value invalid in grid

Reported by canaltin...@gmail.com, Jul 20 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Steps to reproduce the problem:
1. Enter this to url bar: `data:text/html,<div id="foo" style="grid-template-rows: [a] repeat(2, [b] 20px)"></div><script>alert(foo.style.gridTemplateRows);</script>`

What is the expected behavior?
Should print "[a b] 20px [b] 20px".

What went wrong?
It prints "[a] [b] 20px [b] 20px" instead.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 59.0.3071.115  Channel: stable
OS Version: OS X 10.12.5
Flash Version: 

"[a] [b] 20px [b] 20px" is not a valid <track-list> value and it's not roundtripping with that value. `[a] [b]` should merge instead.
I came across this when I was implementing this in servo. Also there is more fundamental bug filed[1] for repeat function which can make this obsolete. But computed value of this repeat function can be properly serialize. The problem is just about specified value. I think it is more straightforward to fix this first.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=716114
 

Comment 1 by eco...@igalia.com, Jul 20 2017

Cc: jfernan...@igalia.com r...@igalia.com
Labels: Needs-Bisect Needs-Triage-M61 OS-Windows
Able to reproduce this issue on Latest Canary#61.0.3062.0 for 'Win7'.
Labels: -Needs-Bisect M-61 OS-Linux
Status: Untriaged (was: Unconfirmed)
Able to reprodcue the issue using #59.0.3071.115 on Mac 10.12.5, Win 10 and Linux Ubuntu 14.04. Observed "[a] [b] 20px [b] 20px" instead "[a b] 20px [b] 20px".

Observig "undefined" error message in Chrome M57, <M57 on enetering the above script. Please find the screenshot.

Considering this issue as Non-Regression issue and untriaging to get more input's from dev.

Note:
1. Issue is seen in M61 as well.
2. Removing bisect label as this a Non-Regression issue.

Thanks!!

 
Screenshot (8).png
59.2 KB View Download

Comment 4 by r...@igalia.com, Jul 21 2017

Cc: svil...@igalia.com
Components: -Blink>Layout Blink>Layout>Grid
Labels: -OS-Linux -OS-Windows -OS-Mac OS-All
Status: Available (was: Untriaged)
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 23

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-2 Pri-3
Status: Available (was: Untriaged)

Sign in to add a comment