New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747061 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: !preview_callbacks_.empty() in print_preview_handler.cc

Project Member Reported by ClusterFuzz, Jul 20 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4828788155482112

Fuzzer: ipc_fuzzer_gen
Job Type: linux_asan_chrome_ipc_32bit
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !preview_callbacks_.empty() in print_preview_handler.cc
  PrintPreviewHandler::OnInvalidPrinterSettings
  PrintPreviewUI::OnInvalidPrinterSettings
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_ipc_32bit&range=488146:488167

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4828788155482112


Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: msrchandra@chromium.org
Components: Internals>Printing
Labels: Test-Predator-Wrong-CLs M-61
Owner: rbpotter@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL did not provide any possible suspects.
Using Code Search for the file, "print_preview_handler.cc" assigning to the concern owner who might be related.

rbpotter -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Cc: tsepez@chromium.org
Labels: OS-Chrome OS-Mac OS-Windows
Tom, should we just kill the renderer with bad_message::ReceivedBadMessage() instead of failing the CHECK() in the browser?

Comment 3 by tsepez@chromium.org, Jul 25 2017

SGTM.  Pretty much anytime we can turn a CHECK() in the browser into a BadMessageReceived(), we move in the right direction.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ece6086bea53e5744e2c294211633a31c8c1c722

commit ece6086bea53e5744e2c294211633a31c8c1c722
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Jul 28 16:34:19 2017

Print Preview Web UI: Change CHECK to ReceivedBadMessage

Crash the renderer, not the browser, if we get an unexpected print
preview IPC message.

Bug:  747061 
Change-Id: I63d5a10e075a6992b3bb7140e2430d135ed341ef
Reviewed-on: https://chromium-review.googlesource.com/585785
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490426}
[modify] https://crrev.com/ece6086bea53e5744e2c294211633a31c8c1c722/chrome/browser/bad_message.h
[modify] https://crrev.com/ece6086bea53e5744e2c294211633a31c8c1c722/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/ece6086bea53e5744e2c294211633a31c8c1c722/chrome/browser/ui/webui/print_preview/print_preview_handler.h
[modify] https://crrev.com/ece6086bea53e5744e2c294211633a31c8c1c722/tools/metrics/histograms/enums.xml

Project Member

Comment 5 by ClusterFuzz, Jul 29 2017

ClusterFuzz has detected this issue as fixed in range 490417:490429.

Detailed report: https://clusterfuzz.com/testcase?key=4828788155482112

Fuzzer: ipc_fuzzer_gen
Job Type: linux_asan_chrome_ipc_32bit
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !preview_callbacks_.empty() in print_preview_handler.cc
  PrintPreviewHandler::OnInvalidPrinterSettings
  PrintPreviewUI::OnInvalidPrinterSettings
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_ipc_32bit&range=488146:488167
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_ipc_32bit&range=490417:490429

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4828788155482112


See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Jul 29 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4828788155482112 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment