CHECK failure: !preview_callbacks_.empty() in print_preview_handler.cc |
|||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=4828788155482112 Fuzzer: ipc_fuzzer_gen Job Type: linux_asan_chrome_ipc_32bit Platform Id: linux Crash Type: CHECK failure Crash Address: Crash State: !preview_callbacks_.empty() in print_preview_handler.cc PrintPreviewHandler::OnInvalidPrinterSettings PrintPreviewUI::OnInvalidPrinterSettings Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_ipc_32bit&range=488146:488167 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4828788155482112 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Jul 25 2017
Tom, should we just kill the renderer with bad_message::ReceivedBadMessage() instead of failing the CHECK() in the browser?
,
Jul 25 2017
SGTM. Pretty much anytime we can turn a CHECK() in the browser into a BadMessageReceived(), we move in the right direction.
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ece6086bea53e5744e2c294211633a31c8c1c722 commit ece6086bea53e5744e2c294211633a31c8c1c722 Author: rbpotter <rbpotter@chromium.org> Date: Fri Jul 28 16:34:19 2017 Print Preview Web UI: Change CHECK to ReceivedBadMessage Crash the renderer, not the browser, if we get an unexpected print preview IPC message. Bug: 747061 Change-Id: I63d5a10e075a6992b3bb7140e2430d135ed341ef Reviewed-on: https://chromium-review.googlesource.com/585785 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#490426} [modify] https://crrev.com/ece6086bea53e5744e2c294211633a31c8c1c722/chrome/browser/bad_message.h [modify] https://crrev.com/ece6086bea53e5744e2c294211633a31c8c1c722/chrome/browser/ui/webui/print_preview/print_preview_handler.cc [modify] https://crrev.com/ece6086bea53e5744e2c294211633a31c8c1c722/chrome/browser/ui/webui/print_preview/print_preview_handler.h [modify] https://crrev.com/ece6086bea53e5744e2c294211633a31c8c1c722/tools/metrics/histograms/enums.xml
,
Jul 29 2017
ClusterFuzz has detected this issue as fixed in range 490417:490429. Detailed report: https://clusterfuzz.com/testcase?key=4828788155482112 Fuzzer: ipc_fuzzer_gen Job Type: linux_asan_chrome_ipc_32bit Platform Id: linux Crash Type: CHECK failure Crash Address: Crash State: !preview_callbacks_.empty() in print_preview_handler.cc PrintPreviewHandler::OnInvalidPrinterSettings PrintPreviewUI::OnInvalidPrinterSettings Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_ipc_32bit&range=488146:488167 Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_ipc_32bit&range=490417:490429 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4828788155482112 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Jul 29 2017
ClusterFuzz testcase 4828788155482112 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue. |
|||
►
Sign in to add a comment |
|||
Comment 1 by msrchandra@chromium.org
, Jul 21 2017Components: Internals>Printing
Labels: Test-Predator-Wrong-CLs M-61
Owner: rbpotter@chromium.org
Status: Assigned (was: Untriaged)