PasswordsSettingsTestCase/testDeletionInDetailView is flaky |
||
Issue descriptionLooking at https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS, PasswordsSettingsTestCase/testDeletionInDetailView and its predecessor PasswordsSettingsTestCase/testDeletion are flaky. The tests so far ultimately pass, but sometimes on the 1st or 2nd retry only. The test attempts to delete a password in the detail password view. That happens through an alert and should dismiss both the alert and the detail password view. Looking at the logs (sample attached), when the test is looking to find the detail view removed and replaced with the password list view, it still finds the detail view. It sounds like draining the UI thread might be in order for that. Unfortunately, this is hard to check with 100% confidence, because it does not reproduce on my local machine (simulator). It does reproduce on the above linked bot consistently, and it also reproduced on https://uberchromegw.corp.google.com/i/internal.bling.tryserver/builders/iphone10-simulator-x64 in the past. When I tried investigating, there was no flake on that bot (I did not find a way to try on EarlGreyiOS without landing the CL first). (I am applying RVG for the internal bot URL.)
,
Jul 20 2017
Attaching the log, which I forgot to do earlier.
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6cb54557603b74f36adad121a042eedffd351c6 commit b6cb54557603b74f36adad121a042eedffd351c6 Author: Vaclav Brozek <vabr@chromium.org> Date: Thu Jul 20 20:27:03 2017 Drain UI thread in PasswordsSettingsTestCase/testDeletionInDetailView As logs from trybots suggest (see the associated bug), the state of the UI during this test sometimes lags behind the test's expectations. This CL attempts to prevent it by draining the UI thread at the moment where the test frequently fails. This was impossible to verify on available trybots, but should at least be verifiable on https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS, where the flake is rather reliable (the test never passes on the very first attempt). TBR=sdefresne@chromium.org Bug: 747058 Change-Id: Ib9cd3c2669357f22bc8d19474c82dabe66801740 Reviewed-on: https://chromium-review.googlesource.com/579972 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#488384} [modify] https://crrev.com/b6cb54557603b74f36adad121a042eedffd351c6/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
,
Jul 20 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by vabr@chromium.org
, Jul 20 2017