Ash "Exiting session" dialog spacing is too cramped |
|||
Issue descriptionchrome fc6bc93f0cb43c4d78b176a14297cfb51b2ed166 r488266 * go/dmstug to set up policy server * enable ShowLogoutButtonInTray pref * Sign in, then click "Sign out" button in shelf Dialog spacing is vertically cramped. Maybe harmony dialog related? Maybe always broken? Code is in ash/system/session/logout_confirmation_dialog.cc. Probably it would be easier to hack the code to show the button or dialog than to set up the policy server.
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05fa15942cc9d70da0e54cce3fcad809fce7b930 commit 05fa15942cc9d70da0e54cce3fcad809fce7b930 Author: Evan Stade <estade@chromium.org> Date: Fri Jul 21 23:42:25 2017 Fix layout of ash logout confirmation dialog. Bug: 747052 Change-Id: I4312c56fc27209167437ba8188d1e2cbd5930565 Reviewed-on: https://chromium-review.googlesource.com/580359 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#488802} [modify] https://crrev.com/05fa15942cc9d70da0e54cce3fcad809fce7b930/ash/system/session/logout_confirmation_dialog.cc
,
Jul 22 2017
,
Jan 22 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by est...@chromium.org
, Jul 20 2017Status: Started (was: Untriaged)
easy hack to make this show: void LogoutConfirmationController::OnLastWindowClosed() {/* if (Shell::Get()->session_controller()->login_status() != LoginStatus::PUBLIC) { return; } */ (then close all windows)